licensecheck: fixes and improvements

[Dmitry Smirnov]

On Fri, 19 Oct 2012 10:51:12 Benjamin Drung wrote:
> > Please find attached patches for licensecheck ('jessie' branch).
> 
> Thanks. I applied patches 2, 4, and 5. For patch 4 I removed
> print-defaults and tests from the GetOptions line. For patch 5 I
> modified the indentation of the return statement and let the comment
> begin with an capital letter.
> 

Thank you.

> Re code style: How should values assigned: "x = 5" or "x=5"?
> 

Whatever you like more -- either way is OK for me, I don't have strong 
preference.


> Patch 1 and 3 look good. Before applying, I like to see the files that
> triggers the wrong result fixed by these patches.
> 

For patch 1 you can find case in #688843 (as mentioned in patch header).
In my email as of 12 of October I attached licensecheck.pl with embedded test 
case for this (see line 1212).


Patch 3 is self-explanatory -- it is super-pedantic  ;)  to ask for license 
text for such case but we have it in the licensecheck.pl attached to my email 
as of 12 of October test #21 (see line 829). This patch fixes version 
detection -- without it GPL-3 may be detected as GPL.


Regards,
Dmitry.