Bug#687452: devscripts: fails to recognize licenses in (fixed-form) Fortran code

[Francesco Poli]

Control: tags 687452 + patch


On Wed, 12 Sep 2012 22:53:20 +0200 Benjamin Drung wrote:

> Am Mittwoch, den 12.09.2012, 22:43 +0200 schrieb Francesco Poli
> (wintermute):
> > I hope that fixing this issue is not too hard and may be done soon
> > (through an upload to experimental, since I don't expect behavioral changes
> > in unstable or testing during a freeze...).
> 

Hello Benjamin,
thanks a lot for your fast reply!   :-)

> Patches are welcome otherwise I can't promise that this bug will be
> fixed.

OK, this is my attempt to fix the bug.

I tested a modified licensecheck on the minimal test case that I
provided and on a directory tree containing about 11400 files to scan.
It seems that It Works For Me™.

So maybe I have a patch...
I wish the BTS supported the "maybe-patch" tag!   ;-)

Take into account that my Perl knowledge is just a smattering
and it is rusty, too...
So please, test my patch accurately.

Legal details: I hereby release my patch under the same licensing terms
as licensecheck (that is to say, under the GNU GPL version 2 or later).

> 
> I assume (depends on the actual change) that the fix can go into
> unstable and migrate to testing. Our git repository has currently some
> bug fixes that I want to get into testing.

This is something you will have to discuss with the release team:
I have no experience of such discussions, so I won't try to predict the
outcome...


Thanks for your time and responsiveness!
Bye.


-- 
 http://www.inventati.org/frx/frx-gpg-key-transition-2010.txt
 New GnuPG key, see the transition document!
..................................................... Francesco Poli .
 GnuPG key fpr == CA01 1147 9CD2 EFDF FB82  3925 3E1C 27E1 1F69 BFFE
-------------- next part --------------
A non-text attachment was scrubbed...
Name: licensecheck_fortranbugfix.patch.gz
Type: application/octet-stream
Size: 526 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/devscripts-devel/attachments/20120913/9f1a9fd4/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/devscripts-devel/attachments/20120913/9f1a9fd4/attachment.pgp>