Bug#687452: devscripts: fails to recognize licenses in (fixed-form) Fortran code

[Benjamin Drung]

Am Donnerstag, den 13.09.2012, 00:08 +0200 schrieb Francesco Poli:
> Control: tags 687452 + patch
> 
> 
> On Wed, 12 Sep 2012 22:53:20 +0200 Benjamin Drung wrote:
> 
> > Am Mittwoch, den 12.09.2012, 22:43 +0200 schrieb Francesco Poli
> > (wintermute):
> > > I hope that fixing this issue is not too hard and may be done soon
> > > (through an upload to experimental, since I don't expect behavioral changes
> > > in unstable or testing during a freeze...).
> > 
> 
> Hello Benjamin,
> thanks a lot for your fast reply!   :-)

I will try to not let it happen again. ;)

> > Patches are welcome otherwise I can't promise that this bug will be
> > fixed.
> 
> OK, this is my attempt to fix the bug.
> 
> I tested a modified licensecheck on the minimal test case that I
> provided and on a directory tree containing about 11400 files to scan.
> It seems that It Works For Me™.
> 
> So maybe I have a patch...
> I wish the BTS supported the "maybe-patch" tag!   ;-)
> 
> Take into account that my Perl knowledge is just a smattering
> and it is rusty, too...

My Perl foo isn't that good either.

Why did you move the Fortran comment removal line up to the top of the
block?

> So please, test my patch accurately.

It passes all licensecheck tests (in test/test_licensecheck). There
aren't that many test for licensecheck, but the test suite will grow
with every bug report. I adapted your test case for the test suite (file
attached).

> Legal details: I hereby release my patch under the same licensing terms
> as licensecheck (that is to say, under the GNU GPL version 2 or later).
> 
> > 
> > I assume (depends on the actual change) that the fix can go into
> > unstable and migrate to testing. Our git repository has currently some
> > bug fixes that I want to get into testing.
> 
> This is something you will have to discuss with the release team:
> I have no experience of such discussions, so I won't try to predict the
> outcome...
> 
> 
> Thanks for your time and responsiveness!
> Bye.

-- 
Benjamin Drung
Debian & Ubuntu Developer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bsd.f
Type: text/x-fortran
Size: 1368 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/devscripts-devel/attachments/20120913/6f840bcf/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/devscripts-devel/attachments/20120913/6f840bcf/attachment.pgp>