Bug#687452: devscripts: fails to recognize licenses in (fixed-form) Fortran code

[Francesco Poli]

On Wed, 19 Sep 2012 14:32:31 +0200 Benjamin Drung wrote:

> Am Donnerstag, den 13.09.2012, 19:06 +0200 schrieb Francesco Poli:
> > On Thu, 13 Sep 2012 01:30:25 +0200 Benjamin Drung wrote:
[...]
> > > Why did you move the Fortran comment removal line up to the top of the
> > > block?
> > 
> > For consistency with the other comment about C / C++ ...
> 
> I was referring to the line of code, not the comment. ;)

Whoops, it seems that I misread your question!   :p
Instead of reading "the Fortran comment removal line", I happened to
read "the Fortran comment removal *comment*"...    D'oh!

Now I understand your question correctly (hopefully) and I can reply.

Moving the comment removal statement up to the top of the block is
crucial: it allows the removal of "[cC] " at the beginning of each line
of text

  $content =~ s/^[cC] //gm;

*before* the following statement removes all tabs and all newline
characters:

  $content =~ tr/\t\r\n/ /;

> 
> Moving the changed line of code down, let's the test case fail.

That's expected, for the reason explained above.

> 
> Having the comment on a separate line is fine. I have applied your
> previous patch and added the test case. Thanks for your contribution.

That's really great news!   :-)
Thanks to you for dealing with this bug so quickly and effectively.

Bye.

-- 
 http://www.inventati.org/frx/frx-gpg-key-transition-2010.txt
 New GnuPG key, see the transition document!
..................................................... Francesco Poli .
 GnuPG key fpr == CA01 1147 9CD2 EFDF FB82  3925 3E1C 27E1 1F69 BFFE
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/devscripts-devel/attachments/20120919/fbd0dc50/attachment.pgp>