Bug#687452: devscripts: fails to recognize licenses in (fixed-form) Fortran code
Benjamin Drung
bdrung at debian.org
Wed Sep 19 12:32:31 UTC 2012
Am Donnerstag, den 13.09.2012, 19:06 +0200 schrieb Francesco Poli:
> On Thu, 13 Sep 2012 01:30:25 +0200 Benjamin Drung wrote:
>
> > Am Donnerstag, den 13.09.2012, 00:08 +0200 schrieb Francesco Poli:
> [...]
> > > OK, this is my attempt to fix the bug.
> > >
> > > I tested a modified licensecheck on the minimal test case that I
> > > provided and on a directory tree containing about 11400 files to scan.
> > > It seems that It Works For Me™.
> [...]
> > >
> > > Take into account that my Perl knowledge is just a smattering
> > > and it is rusty, too...
> >
> > My Perl foo isn't that good either.
> >
> > Why did you move the Fortran comment removal line up to the top of the
> > block?
>
> For consistency with the other comment about C / C++ ...
I was referring to the line of code, not the comment. ;)
Moving the changed line of code down, let's the test case fail.
Having the comment on a separate line is fine. I have applied your
previous patch and added the test case. Thanks for your contribution.
--
Benjamin Drung
Debian & Ubuntu Developer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/devscripts-devel/attachments/20120919/f8d635bb/attachment.pgp>
More information about the devscripts-devel
mailing list