mk-origtargz: Use the already parsed $data to check for Files-Excluded
Joachim Breitner
nomeata at debian.org
Sun May 4 20:33:05 UTC 2014
Dear James,
thanks for checking and cleaning my code. I just saw this patch:
commit 0bb86058a07a83908200af96764acb6ec1b307b2
Author: James McCoy <jamessan at debian.org>
Date: Thu Apr 24 00:29:04 2014 -0400
mk-origtargz: Use the already parsed $data to check for Files-Excluded
If Files-Excluded is present in a copyright file, then it should be a
valid file for parsing by Dpkg::Control::Hash, so use
$data->{'files-excluded'} to see if the field was specified. If it was,
then we can check for a valid format, without the need to re-read the
copyright file.
Signed-off-by: James McCoy <jamessan at debian.org>
I explicitly did the "read file and grep for Files-Excluded" to print
the warning even if Dpkg::Control::Hash did not manage to parse the
file; it might be a non-machine-readable file that someone added a
Files-Excluded anywhere, or it might have been added to the wrong
section – don’t you think it’s be useful to warn the user in that case
as well?
Greetings,
Joachim
--
Joachim "nomeata" Breitner
Debian Developer
nomeata at debian.org | ICQ# 74513189 | GPG-Keyid: F0FBF51F
JID: nomeata at joachim-breitner.de | http://people.debian.org/~nomeata
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/devscripts-devel/attachments/20140504/8418e81d/attachment.sig>
More information about the devscripts-devel
mailing list