devscripts testsuite failure on raspbian.

[Osamu Aoki]

Hi,

On Sun, Jan 31, 2016 at 04:17:23PM +0000, Peter Green wrote:
> In raspbian stretch devscripts is failing with.

So you are building for derivatives :-)  Currently, Ubuntu case is
supported but not for others...
 
> >testFileExclusion
...
> >uscan: Executing user specified script:
> >    uupdate --no-symlink --upstream-version 1+dfsg1 ../foo_1+dfsg1.orig.tar.gz
> >uupdate: New Release will be 1+dfsg1-0raspbian1.
                                        ^^^^^^^^^^
> >uupdate: Untarring the new sourcecode archive ../foo_1+dfsg1.orig.tar.gz
> >uupdate: debian/source/format is "3.0 (quilt)".
> >uupdate: Auto-generating foo_0+dfsg1-1.debian.tar.xz
> >uupdate: Unpacking the debian/ directory from version 0+dfsg1-1 worked fine.
> >uupdate: Remember: Your current directory is the OLD sourcearchive!
> >uupdate: Do a "cd ../foo-1+dfsg1" to see the new package
> >ASSERT:uscan: Version should be 1+dfsg1-1 but 1+dfsg1-0raspbian1 expected:<1+dfsg1-0raspbian1>  but was:<1+dfsg1-1>
                                   ^^^^^^^^^     ^^^^^^^^^^^^^^^^^^           ^^^^^^^^^^^^^^^^^^            ^^^^^^^^^
> It seems that the program itself and it's testsuite are making different
> assumptions about what the version numbering should be. I have no idea where
> to start on fixing this though.

Testsuite asasumes Debian unless Ubuntu.

Look at first part of test/test_uscan:
| SUFFIX="1"
| if which dpkg-vendor >/dev/null 2>&1; then
|     case "$(dpkg-vendor --query Vendor 2>/dev/null)" in
|         "Ubuntu")
|             SUFFIX="0ubuntu1"
|             ;;
|     esac
| fi

Please check what "dpkg-vendor --query Vendor 2>/dev/null" returns on
rasbian and add code for rasbian.  My wild guess is:

| SUFFIX="1"
| if which dpkg-vendor >/dev/null 2>&1; then
|     case "$(dpkg-vendor --query Vendor 2>/dev/null)" in
|         "Ubuntu")
|             SUFFIX="0ubuntu1"
|             ;;
|         "Rasbian")
|             SUFFIX="0rasbian1"
|             ;;
|     esac
| fi

Please submit tested patch.  (Maybe all non-Debian should be dealt like
this by using lower case.

Osamu