Bug#829646: mk-origtargz: Files-Excluded-Ignore

[Osamu Aoki]

Hi,

On Tue, Jul 05, 2016 at 11:12:36AM +1000, Dmitry Smirnov wrote:
> Package: devscripts
> Version: 2.16.6
> Severity: wishlist
> 
> In Golang team we routinely use (very useful) Files-Excluded
> feature to get rid of bundled/vendored libraries.
> 
> Usually we can remove all 3rd party libs but occasionally few dependencies
> should be preserved in which case we have to maintain explicit long lists
> of exclusions like in following example:
> 
> http://anonscm.debian.org/cgit/docker/docker.io.git/tree/debian/copyright?h=experimental
> 
> IMHO it could be useful to be able to drop everything _but_ some folders:
> 
>     Files-Excluded: vendor/src/*
>     Files-Excluded-Ignore: vendor/src/github.com/docker/notary

This is valid and high priority wishlist which needs to be implemented.

> hence I'd like to propose new "Files-Excluded-Ignore" field.

As I see your link in the above;

Comment:
 "@" marks circular dependencies.
 "%" marks FTBFS.

What are these.  I see you have:
  @vendor/src/github.com/docker/notary
in your Files-Excluded:

Also, the code written to do this exclusion is via @exclude_globs.  

To address this issue, changes are needed around the code:
  @exclude_info = map { { glob => $_, used => 0, regex => glob_to_regex($_) } } @exclude_globs;
... (See around line 477)

I am scared to touch this part.  (I do not like code with $_)

Send us a tested patch.

Also make sure not to break the current Files-Excluded-<component>: style
exclusion for multi-upstream tarball package.

Osamu