Bug#841149: devscripts: Improvements for debrepro script

Guillem Jover guillem at debian.org
Tue Oct 18 22:21:41 UTC 2016


Hi!

On Mon, 2016-10-17 at 23:14:01 -0400, James McCoy wrote:
> Thanks for the patches!  I think the first patch is straight forward
> enough.  I'll let Antonio comment on whether he wants to apply the other
> two.  I just had one comment, inline.

Perfect thanks!

> > @@ -83,13 +81,9 @@ create_build_script() {
> >      echo 'cd ../disorderfs'
> >    fi
> >  
> > -  echo
> > -  echo 'dpkg-source --before-build .'
> > -  echo 'fakeroot debian/rules clean'
> > -
> >    variation date
> > -  vary 'fakeroot debian/rules binary' \
> > -    'faketime "+213days +7hours +13minutes" fakeroot debian/rules binary'
> > +  vary 'dpkg-buildpackage -b' \
> > +    'dpkg-buildpackage -b -r"faketime +213days+7hours+13minutes fakeroot"'
> 
> Shouldn't these use "-us -uc" too?  The intention of debrepro is just to
> check for variance, not to produce something to upload, so I don't think
> it should default to signing.

Ah, indeed sorry, I've gotten used to not pass those anymore as I've
set them as default on my ~/.config/dpkg/buildpackage.conf file. :)

Attached rebased and fixed patches.

Thanks,
Guillem
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-debrepro-Use-dpkg-buildpackage-instead-of-ad-hoc-cod.patch
Type: text/x-diff
Size: 1306 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/devscripts-devel/attachments/20161019/c30f8974/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-debrepro-Compare-.changes-files-and-fallback-to-use-.patch
Type: text/x-diff
Size: 2340 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/devscripts-devel/attachments/20161019/c30f8974/attachment-0001.patch>


More information about the devscripts-devel mailing list