Bug#841149: devscripts: Improvements for debrepro script

[Antonio Terceiro]

On Wed, Oct 19, 2016 at 12:21:41AM +0200, Guillem Jover wrote:
> Hi!
> 
> On Mon, 2016-10-17 at 23:14:01 -0400, James McCoy wrote:
> > Thanks for the patches!  I think the first patch is straight forward
> > enough.  I'll let Antonio comment on whether he wants to apply the other
> > two.  I just had one comment, inline.
> 
> Perfect thanks!
> 
> > > @@ -83,13 +81,9 @@ create_build_script() {
> > >      echo 'cd ../disorderfs'
> > >    fi
> > >  
> > > -  echo
> > > -  echo 'dpkg-source --before-build .'
> > > -  echo 'fakeroot debian/rules clean'
> > > -
> > >    variation date
> > > -  vary 'fakeroot debian/rules binary' \
> > > -    'faketime "+213days +7hours +13minutes" fakeroot debian/rules binary'
> > > +  vary 'dpkg-buildpackage -b' \
> > > +    'dpkg-buildpackage -b -r"faketime +213days+7hours+13minutes fakeroot"'
> > 
> > Shouldn't these use "-us -uc" too?  The intention of debrepro is just to
> > check for variance, not to produce something to upload, so I don't think
> > it should default to signing.
> 
> Ah, indeed sorry, I've gotten used to not pass those anymore as I've
> set them as default on my ~/.config/dpkg/buildpackage.conf file. :)
> 
> Attached rebased and fixed patches.

Looks good (and works) for me. Just merged and pushed your patches.

Thanks
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/devscripts-devel/attachments/20161019/6996f0c4/attachment.sig>