Bug#868260: devscripts: phantom script debdiff-apply

[gregor herrmann]

On Thu, 13 Jul 2017 21:24:16 -0400, James McCoy wrote:

> On Thu, Jul 13, 2017 at 10:59:43PM +0200, gregor herrmann wrote:
> > I looked at the source package, without finding anything obvious.
> > And rebuilding the package fails without internet access in the
> > chroot (and/or with http_proxy set in the chroot).
> 
> It certainly shouldn't require internet access.  However, we do run some
> uscan tests and uscan honors proxy settings in the environment.
> 
> I guess we should be clearing any of those when testing, just in case
> they happen to leak into the test environment.

Indeed, with the attache patch tge uscan tests seem to pass.
(There might be more variables to consider and better places to unset
them ...)



I still get the following test failure afterwards:

test_debdiff-apply (devscripts.test.test_help.HelpTestCase) ... test_comments_parsing_fns
FAIL
/usr/lib/python3.6/unittest/case.py:633: ResourceWarning: unclosed file <_io.BufferedReader name=4>
  outcome.errors.clear()
/usr/lib/python3.6/unittest/case.py:633: ResourceWarning: unclosed file <_io.BufferedReader name=6>
  outcome.errors.clear()
test_sadt (devscripts.test.test_help.HelpTestCase) ... test_coproc
/usr/lib/python3.6/unittest/case.py:605: ResourceWarning: unclosed file <_io.BufferedReader name=4>
  testMethod()
/usr/lib/python3.6/unittest/case.py:605: ResourceWarning: unclosed file <_io.BufferedReader name=6>
  testMethod()
ok
test_suspicious-source (devscripts.test.test_help.HelpTestCase) ... test_dynamic_length
test_exit_code
ok
test_wrap-and-sort (devscripts.test.test_help.HelpTestCase) ... test_fail2ban
ok
testArgs (devscripts.test.test_logger.LoggerTestCase) ... ok
testCommand (devscripts.test.test_logger.LoggerTestCase) ... ok
testNoArgs (devscripts.test.test_logger.LoggerTestCase) ... ok
test_pylint (devscripts.test.test_pylint.PylintTestCase)
Test: Run pylint on Python source code ... test_fps
test_functions
skipped 'pylint crashed :/'

======================================================================
FAIL: test_debdiff-apply (devscripts.test.test_help.HelpTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/build/devscripts-2.17.9/scripts/devscripts/test/test_help.py", line 75, in tester
    % (script, TIMEOUT, ''.encode('ascii').join(out)))
AssertionError: 1 != 0 : debdiff-apply failed to return usage within 5 seconds.
Output:
b'Traceback (most recent call last):\n  File "./debdiff-apply", line 29, in <module>\n    import unidiff\nImportError: No$

----------------------------------------------------------------------
Ran 8 tests in 0.851s

FAILED (failures=1, skipped=1)
Test failed: <unittest.runner.TextTestResult run=8 errors=0 failures=1>
error: Test failed: <unittest.runner.TextTestResult run=8 errors=0 failures=1>
Makefile:92: recipe for target 'test' failed
make[2]: *** [test] Error 1
make[2]: Leaving directory '/build/devscripts-2.17.9/scripts'
Makefile:58: recipe for target 'test_scripts' failed
make[1]: *** [test_scripts] Error 2
make[1]: *** Waiting for unfinished jobs....



Cheers,
gregor


-- 
 .''`.  https://info.comodo.priv.at/ - Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Bettina Wegner: Wenn du mir nicht mehr ins Gesicht siehst
-------------- next part --------------
A non-text attachment was scrubbed...
Name: uscan_test_http_proxy.diff
Type: text/x-diff
Size: 563 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/devscripts-devel/attachments/20170715/f1bdfbb6/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: Digital Signature
URL: <http://lists.alioth.debian.org/pipermail/devscripts-devel/attachments/20170715/f1bdfbb6/attachment.sig>