Bug#868260: devscripts: phantom script debdiff-apply

[Ximin Luo]

On Sat, 15 Jul 2017 22:20:06 +0200 gregor herrmann <gregoa at debian.org> wrote:
> On Thu, 13 Jul 2017 21:24:16 -0400, James McCoy wrote:
> 
> > On Thu, Jul 13, 2017 at 10:59:43PM +0200, gregor herrmann wrote:
> > > I looked at the source package, without finding anything obvious.
> > > And rebuilding the package fails without internet access in the
> > > chroot (and/or with http_proxy set in the chroot).
> > 
> > It certainly shouldn't require internet access.  However, we do run some
> > uscan tests and uscan honors proxy settings in the environment.
> > 
> > I guess we should be clearing any of those when testing, just in case
> > they happen to leak into the test environment.
> 
> Indeed, with the attache patch tge uscan tests seem to pass.
> (There might be more variables to consider and better places to unset
> them ...)
> 
> 
> 
> I still get the following test failure afterwards:
> 
> [,,]
> 
> ======================================================================
> FAIL: test_debdiff-apply (devscripts.test.test_help.HelpTestCase)
I pushed a fix to git, adding a B-D on debdiff-apply's dependency python3-unidiff. Together with your uscan http_proxy patch, does this fix all the tests for you?

If not, it might be good if we export http_proxy = http://127.0.0.1:9/ and https_proxy = https://127.0.0.1:9/ in d/rules, pybuild does this automatically already - https://wiki.debian.org/Python/Pybuild#debian.2Fcontrol

X

-- 
GPG: ed25519/56034877E1F87C35
GPG: rsa4096/1318EFAC5FBBDBCE
https://github.com/infinity0/pubkeys.git