Bug#762715: updates to dch --lts

Mattia Rizzolo mattia at debian.org
Mon Oct 23 14:52:01 UTC 2017


Hi!

On Mon, Oct 23, 2017 at 10:33:58AM -0400, Antoine Beaupré wrote:
> I figured I would do *some* refactoring while I was there to avoid
> further code duplication.

YES!  Please refactor it all :D

> I haven't tested all scenarios (and the test suite is limited inthat
> regard) but this mostly works in my tests locally.

I'd be very happy if you could expand the testsuite some more: that's
one reason why refactoring that thing is so unappealing, breakages are
very easy to miss.  I'd actually take that patch before the others.


(I haven't reviewed the patches just yet, but from a quick look they
seem sane at least)

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/devscripts-devel/attachments/20171023/e46638bf/attachment.sig>


More information about the devscripts-devel mailing list