Bug#762715: updates to dch --lts

[Antoine Beaupré]

On 2017-10-23 16:52:01, Mattia Rizzolo wrote:
> Hi!
>
> On Mon, Oct 23, 2017 at 10:33:58AM -0400, Antoine Beaupré wrote:
>> I figured I would do *some* refactoring while I was there to avoid
>> further code duplication.
>
> YES!  Please refactor it all :D
>
>> I haven't tested all scenarios (and the test suite is limited inthat
>> regard) but this mostly works in my tests locally.
>
> I'd be very happy if you could expand the testsuite some more: that's
> one reason why refactoring that thing is so unappealing, breakages are
> very easy to miss.  I'd actually take that patch before the others.
>
>
> (I haven't reviewed the patches just yet, but from a quick look they
> seem sane at least)

I think what we would need here is a "before/after" set of tricky
changelog files and flags. Building such a corpus takes time,
unfortunately, but the actual tests shouldn't be that hard...

The problem is there are so many options in dch now that the combination
of options makes the problem space basically exponentional... a
multi-dimentional matrix!

Not sure I have much time to work on this unfortunately...

a.

-- 
The world is a dangerous place, not because of those who do evil,
but because of those who look on and do nothing.
                        - Albert Einstein