[devscripts] branch master updated (96b67fa -> 8536b84)

[Osamu Aoki]

Hi,

On Fri, Sep 29, 2017 at 09:50:12AM +0200, Christoph Berg wrote:
> Re: Osamu Aoki 2017-09-28 <20170928125625.uvpux6wmsjqyo6ys at goofy.tc4.so-net.ne.jp>
> > >       from  96b67fa   Expand changelog based on output of gbp dch --git-log="--author=Chris" --since=v2.17.10
> > >        new  8536b84   origtargz: Add --force-download to uscan --download-current version; recent uscan versions require it.
> > 
> > Is this some regression?  Then maybe I should fix it in uscan instead if
> > this makes more sense.
> > 
> > When I refactor logic, some fine touches are lost.
> 
> Hi,
> 
> the regression is that uscan refuses to download the current version
> from debian/changelog when "uscan --download" is used. Consequently,
> "uscan --download-current-version" is also broken. 

That's makes sense with current code.  My posted patch fixes that and
few other cases where --force-bad-version is applying for uupdate.

>  I wasn't complaining earlier about that because I suspected some plan
>  behind that part of the change, but I guess the blame is with me for
>  not speaking up when I first noticed it.
> 
> USCAN settings from my .devscripts file:
> 
> USCAN_FORCE_DOWNLOAD=yes

Hi, there is no such parameter to set. (Both in manpage and in code)
I kind of understand feeling why you expected ...

(Anyway, code around wasn't updated when command line options are added
previously.  These user interface were not designed together.  So if
people add one feature to one side, )

> USCAN_DOWNLOAD=no

>From this interface, $download is set to 0 (--no-download)
(If =yes, $download is set to 1 which is default.  No other values are allowed)

This $download has 4 states:
# $download:   0 = no-download,
#              1 = download (default, only-new),
#              2 = force-download (even if file is up-to-date version),
#              3 = overwrite-download (even if file exists)

If --force-bad-version case (version is older), $download needs to be
set 2.  I recall changing code around this to simplify code.

> USCAN_PASV=yes
> USCAN_SYMLINK=rename
> USCAN_VERBOSE=yes

Osamu