[devscripts] branch master updated (96b67fa -> 8536b84)

[Christoph Berg]

Re: Osamu Aoki 2017-09-29 <20170929122807.le4dns2qb4neepsw at goofy.tc4.so-net.ne.jp>
> That's makes sense with current code.  My posted patch fixes that and
> few other cases where --force-bad-version is applying for uupdate.

Hi,

thanks for the patch! Unfortunately, it isn't enough yet:

[0] 20:42 cbe at lehmann:~/postgresql/unit/unit master 1j $ uscan --download-current-version --rename
uscan info: uscan (version ###VERSION###) See uscan(1) for help
uscan info: Scan watch files in .
uscan info: Check debian/watch and debian/changelog in ./.git/refs/tags
uscan info: Check debian/watch and debian/changelog in .
uscan info: package="postgresql-unit" version="3.0-2" (as seen in debian/changelog)
uscan info: package="postgresql-unit" version="3.0" (no epoch/revision)
uscan info: ./debian/changelog sets package="postgresql-unit" version="3.0"
uscan info: Process ./debian/watch (package=postgresql-unit version=3.0)
uscan info: Last orig.tar.* tarball version (from debian/changelog): 3.0
uscan info: Download the --download-current-version specified version: 3.0
uscan info: Requesting URL:
   https://github.com/ChristophBerg/postgresql-unit/releases
uscan info: Matching pattern:
   (?:(?:https://github.com)?\/ChristophBerg\/postgresql\-unit\/releases)?.*/(.*).tar.gz
uscan info: Found the following matching hrefs on the web page (newest first):
   /ChristophBerg/postgresql-unit/archive/debian/4.0-2.tar.gz (4.0-2) index=4.0-2-1 
   /ChristophBerg/postgresql-unit/archive/4.0.tar.gz (4.0) index=4.0-1 
   /ChristophBerg/postgresql-unit/archive/3.1.tar.gz (3.1) index=3.1-1 
   /ChristophBerg/postgresql-unit/archive/3.0.tar.gz (3.0) index=3.0-1 matched with the download version
   /ChristophBerg/postgresql-unit/archive/2.0.tar.gz (2.0) index=2.0-1 
   /ChristophBerg/postgresql-unit/archive/1.1.tar.gz (1.1) index=1.1-1 
   /ChristophBerg/postgresql-unit/archive/1.0.tar.gz (1.0) index=1.0-1 
uscan info: Matching target for downloadurlmangle: https://github.com/ChristophBerg/postgresql-unit/archive/3.0.tar.gz
uscan info: Upstream URL (downloadurlmangled):
   https://github.com/ChristophBerg/postgresql-unit/archive/3.0.tar.gz
uscan info: Newest upstream tarball version selected for download (uversionmangled): 3.0
uscan info: Download filename (filenamemangled): 3.0.tar.gz
uscan: Newest version of postgresql-unit on remote site is 3.0, specified download version is 3.0
uscan info: Scan finished

[0] 20:42 cbe at lehmann:~/postgresql/unit/unit master 1j $ uscan --download-current-version --rename --force-download
uscan info: uscan (version ###VERSION###) See uscan(1) for help
uscan info: Scan watch files in .
uscan info: Check debian/watch and debian/changelog in ./.git/refs/tags
uscan info: Check debian/watch and debian/changelog in .
uscan info: package="postgresql-unit" version="3.0-2" (as seen in debian/changelog)
uscan info: package="postgresql-unit" version="3.0" (no epoch/revision)
uscan info: ./debian/changelog sets package="postgresql-unit" version="3.0"
uscan info: Process ./debian/watch (package=postgresql-unit version=3.0)
uscan info: Last orig.tar.* tarball version (from debian/changelog): 3.0
uscan info: Download the --download-current-version specified version: 3.0
uscan info: Requesting URL:
   https://github.com/ChristophBerg/postgresql-unit/releases
uscan info: Matching pattern:
   (?:(?:https://github.com)?\/ChristophBerg\/postgresql\-unit\/releases)?.*/(.*).tar.gz
uscan info: Found the following matching hrefs on the web page (newest first):
   /ChristophBerg/postgresql-unit/archive/debian/4.0-2.tar.gz (4.0-2) index=4.0-2-1 
   /ChristophBerg/postgresql-unit/archive/4.0.tar.gz (4.0) index=4.0-1 
   /ChristophBerg/postgresql-unit/archive/3.1.tar.gz (3.1) index=3.1-1 
   /ChristophBerg/postgresql-unit/archive/3.0.tar.gz (3.0) index=3.0-1 matched with the download version
   /ChristophBerg/postgresql-unit/archive/2.0.tar.gz (2.0) index=2.0-1 
   /ChristophBerg/postgresql-unit/archive/1.1.tar.gz (1.1) index=1.1-1 
   /ChristophBerg/postgresql-unit/archive/1.0.tar.gz (1.0) index=1.0-1 
uscan info: Matching target for downloadurlmangle: https://github.com/ChristophBerg/postgresql-unit/archive/3.0.tar.gz
uscan info: Upstream URL (downloadurlmangled):
   https://github.com/ChristophBerg/postgresql-unit/archive/3.0.tar.gz
uscan info: Newest upstream tarball version selected for download (uversionmangled): 3.0
uscan info: Download filename (filenamemangled): 3.0.tar.gz
uscan: Newest version of postgresql-unit on remote site is 3.0, specified download version is 3.0
uscan info: Downloading upstream package: 3.0.tar.gz
uscan info: Requesting URL:
   https://github.com/ChristophBerg/postgresql-unit/archive/3.0.tar.gz
uscan info: Successfully downloaded package: 3.0.tar.gz
uscan info: Start checking for common possible upstream OpenPGP signature files
uscan info: End checking for common possible upstream OpenPGP signature files
uscan info: Missing OpenPGP signature.
uscan info: New orig.tar.* tarball version (oversionmangled): 3.0
uscan info: Executing internal command:
   mk-origtargz --package postgresql-unit --version 3.0 --rename --compression gzip --directory .. --copyright-file debian/copyright ../3.0.tar.gz
uscan info: New orig.tar.* tarball version (after mk-origtargz): 3.0
uscan info: Successfully renamed ../3.0.tar.gz to ../postgresql-unit_3.0.orig.tar.gz.
uscan info: Scan finished

[0] 20:43 cbe at lehmann:~/postgresql/unit/unit master 1j $ head -1 debian/changelog 
postgresql-unit (3.0-2) unstable; urgency=medium

> > USCAN_FORCE_DOWNLOAD=yes
> 
> Hi, there is no such parameter to set. (Both in manpage and in code)

Yeah it was a blind guess, and I eventually noticed it didn't work...

> > USCAN_DOWNLOAD=no
> 
> From this interface, $download is set to 0 (--no-download)
> (If =yes, $download is set to 1 which is default.  No other values are allowed)
> 
> This $download has 4 states:
> # $download:   0 = no-download,
> #              1 = download (default, only-new),
> #              2 = force-download (even if file is up-to-date version),
> #              3 = overwrite-download (even if file exists)
> 
> If --force-bad-version case (version is older), $download needs to be
> set 2.  I recall changing code around this to simplify code.

I have USCAN_DOWNLOAD=no in .devscripts so I can call "uscan" to see
what version would be available. "--download-current-version" should
override that, though, it's called "--download*" after all.

Christoph