[Freewx-maint] Bug#738849: Please enable webview support for wx3.0

[Gianfranco Costamagna]

Hi again Olly.

The package seems to be building fine, running with the split and boinc now builds correctly (I didn't test the run, just the build).

I double checked the libraries, they aren't anymore in the gtk package and they are in the webview one.

I also checked the documentation, and updated it.
https://github.com/LocutusOfBorg/wx/commit/92a5bd8ff7c2347d00beac74f0938689ce706679
https://github.com/LocutusOfBorg/wx/commit/4b357103f85186a8585edb60d0ef6c707dfac5ba


I'm still a little bit worried about the dependencies that I should add for the new packages, can you please review?

The patch was really trivial, it needed just a little time for me once I got the courage for starting
Nothing should be pushed upstream, the package already correctly builds its own library.

I would like to contribute a little more if you want, bumping standard version, maybe cherry-pick the patch from #736374 or would you like to wait for the new upcoming release?

I really would like a positive, negative or whatever feedback (please ask me to test whatever you want, I don't know if I did the whole work correctly)

have a nice weekend
cheers,

Gianfranco 




> Il Giovedì 24 Aprile 2014 18:11, Gianfranco Costamagna <costamagnagianfranco at yahoo.it> ha scritto:
> > Hi Olly, I'm looking right now at the package.
> 
> Enabling webview gives us a new library, so I think a new package is the most 
> feasible way, right? (sorry, the package is quite heavy, I can miss something)
> ldd debian/tmp/usr/bin/boincmgr  |grep wx
>     libwx_gtk2u_webview-3.0.so.0 => 
> /usr/lib/x86_64-linux-gnu/libwx_gtk2u_webview-3.0.so.0 (0x00007fd6b9232000)
> 
> this is the library installed in
> libwxgtk3.0-0_3.0.0 because of
> 
> install-gtk-lib: install-gtk-shared-stamp
> [snip]
>         dh_install -Xmedia 
> $(objdir_gtk_install)/lib/$(DEB_HOST_MULTIARCH)/libwx_gtk*.so.*      
> usr/lib/$(DEB_HOST_MULTIARCH)
> [/snip]
> 
> install-gtk-dev: install-gtk-shared-stamp
> [snip]
>         dh_install -Xmedia 
> $(objdir_gtk_install)/lib/$(DEB_HOST_MULTIARCH)/libwx_gtk*.so        
> usr/lib/$(DEB_HOST_MULTIARCH)
> [snip]
> 
> and I'll look shortly where the headers file are located but I'm pretty 
> sure they are in
> package_headers         := wx$(release)-headers
> 
> since they are included as 
> <wx/webview.h>
> <wx/webviewfshandler.h>
> 
> so can you please suggest me how to move on?
> 
> My opinion:
> -leave headers in the generic package (should check but I'm pretty sure they 
> already are there
> -create a new package? move on -media? this is up to you
> 
> something like libwxgtk-webview=SOV with the library inside and a 
> libwxgtk-webview-dev with the link?
> 
> the patch seems to be really trivial if I'm understanding correctly how does 
> your package work
> 
> cheers,
> 
> Gianfranco
> 
> 
> 
>>  Il Giovedì 17 Aprile 2014 3:03, Olly Betts <olly at survex.com> ha 
> scritto:
>>  > On Wed, Apr 16, 2014 at 07:00:15AM +0100, 
> costamagnagianfranco at yahoo.it wrote:
>>>   Hi Olly, do you have any news on this?
>>>   Boinc 7.4.x is going to be released soon, with webview support, would
>>>   be nice to have it at least in experimental for testing,
>>>   do you think is it possible?
>> 
>>  I seem to be the only active member of the wx maintainers team, and my
>>  wx time is already occupied with trying to migrate the archive away from
>>  2.8.  It would be good if that happened before jessie, and there's 
> still
>>  a lot to do (and this is only the C++ packages - I've not even started
>>  on wxpython yet):
>> 
>>  https://wiki.debian.org/Teams/WxWidgets/Transition2.8to3.0
>> 
>>  So if you want to get webview support with any degree of urgency, 
> you'll
>>  have to do the hard work yourself I'm afraid - just chucking the 
> trivial
>>  patch at me isn't anything like enough.  If someone provides a well
>>  tested and sane patch, I'm very likely to apply it.
>> 
>>  As I've outlined already at
>>  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=738849#22 we can't
>>  have libwxgtk3.0-0 depending on webkit or else people will quite
>>  reasonably complain about the dependency bloat.  The webkit libraries
>>  either need to be loaded dynamically on demand, or else we need a
>>  separate binary package containing just the webkit parts of wx (similar
>>  to libwxgtk-media3.0-0 for wxMediaCtrl).
>> 
>>  To be explicit:
>> 
>>  For webview support, the first thing you probably need to do is check
>>  the binary packages you built from your modified source package and see
>>  what their dependencies are compared to those for the packages currently
>>  in the archive.
>> 
>>  If your changes gain us a dependency on webkit libraries (which seems
>>  likely) you need to either split off that code into a separate library
>>  and put it in its own binary package, or change wx to load those
>>  libraries only when actually used, ideally using the wx wrappers around
>>  dlopen(), dlsym(), etc so we can try to push the patch upstream.
>> 
>>  If you want us to switch to using libnotify instead of the generic wx
>>  implementation, you need to respond to my query (and quoted source code
>>  comment) in comment 22.
>> 
>>  If you want us to enable sdl and libmspack support, you also need to
>>  justify why doing so is useful, and investigate the (direct and
>>  indirect) extra dependencies which each results in.
>> 
>>  Cheers,
>> 
>>      Olly
>> 
>