[Freewx-maint] Bug#738849: Please enable webview support for wx3.0

Olly Betts olly at survex.com
Mon Apr 28 05:47:17 UTC 2014


> Il Giovedì 24 Aprile 2014 18:11, Gianfranco Costamagna <costamagnagianfranco at yahoo.it> ha scritto:
> > Hi Olly, I'm looking right now at the package.
> 
> Enabling webview gives us a new library, so I think a new package is the most 
> feasible way, right?

Yes, seems we should be able to put the "webview" library into a new
binary package (very like how the "mmedia" library is handled).

> My opinion:
> -leave headers in the generic package (should check but I'm pretty sure they 
> already are there

That seems reasonable (and to be what we do for the wxmediactrl
headers).

> something like libwxgtk-webview=SOV with the library inside and a 
> libwxgtk-webview-dev with the link?

Yes.

> the patch seems to be really trivial if I'm understanding correctly how does 
> your package work

If there's already a separate library built, then it shouldn't be a
complex patch, though it still needs careful testing as the simple
changes in the patch can cause major changes in the resulting packages.

> I double checked the libraries, they aren't anymore in the gtk package
> and they are in the webview one.

Have you compared the existing binary packages before and after your
changes with debdiff?  That's a good way to pick up any files that
have inadvertently been installed to a different package, or which
have changed in ways we don't want.

> I also checked the documentation, and updated it.
> https://github.com/LocutusOfBorg/wx/commit/92a5bd8ff7c2347d00beac74f0938689ce706679
> https://github.com/LocutusOfBorg/wx/commit/4b357103f85186a8585edb60d0ef6c707dfac5ba

> I'm still a little bit worried about the dependencies that I should
> add for the new packages, can you please review?

You shouldn't need to add "libwebkitgtk-3.0-0" manually -
${shlibs:Depends} should take care of adding that for you.

I wouldn't make libwebkitgtk-3.0-0-dbg a hard dependency either (as you
can definitely do useful debugging with just the wx debug symbols), but
it might be reasonable to add them as "Suggests:".

> I would like to contribute a little more if you want, bumping standard
> version, maybe cherry-pick the patch from #736374 or would you like to
> wait for the new upcoming release?

I'm not really sure what's up with the upstream 3.0.1 release.  It seems
to be have been close for a while, but with about 5 open bugs (just not
always the same 5), and it's now way past the date on their trac
milestone for it.

If we're going to make an upload for this bug, we might as well bundle
in that patch, plus the one for #746192.

It looks like no changes are required for policy 3.9.5, so that can be
bumped too.

If you're interested in contributing more generally, you might want to
consider joining the team: https://alioth.debian.org/projects/freewx/

Cheers,
    Olly



More information about the Freewx-maint mailing list