[Freewx-maint] Bug#738849: Please enable webview support for wx3.0

Gianfranco Costamagna costamagnagianfranco at yahoo.it
Tue Apr 29 08:45:32 UTC 2014 

Hi Olly!


> Il Lunedì 28 Aprile 2014 7:47, Olly Betts <olly at survex.com> ha scritto:

> >>  Il Giovedì 24 Aprile 2014 18:11, Gianfranco Costamagna 
> <costamagnagianfranco at yahoo.it> ha scritto:
>>  > Hi Olly, I'm looking right now at the package.
>> 
>>  Enabling webview gives us a new library, so I think a new package is the 
> most 
>>  feasible way, right?
> 
> Yes, seems we should be able to put the "webview" library into a new
> binary package (very like how the "mmedia" library is handled).
> 

yes, I started from media package and did some magic sed commands to copy paste

>>  My opinion:
>>  -leave headers in the generic package (should check but I'm pretty sure 
> they 
>>  already are there
> 
> That seems reasonable (and to be what we do for the wxmediactrl
> headers).
> 


mmm the headers were already there, so I don't think we need to change anything here (the files have some magic #ifdef inside)

https://packages.debian.org/sid/amd64/wx3.0-headers/filelist
/usr/include/wx-3.0/wx/webview.h
/usr/include/wx-3.0/wx/webviewarchivehandler.h
/usr/include/wx-3.0/wx/webviewfshandler.h


>>  something like libwxgtk-webview=SOV with the library inside and a 
>>  libwxgtk-webview-dev with the link?
> 
> Yes.
> 

wonderful

>>  the patch seems to be really trivial if I'm understanding correctly how 
> does 
>>  your package work
> 
> If there's already a separate library built, then it shouldn't be a
> complex patch, though it still needs careful testing as the simple
> changes in the patch can cause major changes in the resulting packages.
> 

yes of course

>>  I double checked the libraries, they aren't anymore in the gtk package
>>  and they are in the webview one.
> 
> Have you compared the existing binary packages before and after your
> changes with debdiff?  That's a good way to pick up any files that
> have inadvertently been installed to a different package, or which
> have changed in ways we don't want.
> 

I did some magic test here:
the new packages shows these files

$ dpkg -c libwxgtk-webview3.0-0_3.0.0-3_amd64.deb
drwxr-xr-x root/root         0 2014-04-28 17:34 ./
drwxr-xr-x root/root         0 2014-04-28 17:33 ./usr/
drwxr-xr-x root/root         0 2014-04-28 17:33 ./usr/share/
drwxr-xr-x root/root         0 2014-04-28 17:33 ./usr/share/doc/
drwxr-xr-x root/root         0 2014-04-28 17:34 ./usr/share/doc/libwxgtk-webview3.0-0/
-rw-r--r-- root/root     22859 2014-04-28 09:25 ./usr/share/doc/libwxgtk-webview3.0-0/copyright
-rw-r--r-- root/root     79775 2013-11-11 14:10 ./usr/share/doc/libwxgtk-webview3.0-0/changelog.gz
-rw-r--r-- root/root     18441 2014-04-28 11:04 ./usr/share/doc/libwxgtk-webview3.0-0/changelog.Debian.gz
drwxr-xr-x root/root         0 2014-04-28 17:33 ./usr/share/lintian/
drwxr-xr-x root/root         0 2014-04-28 17:33 ./usr/share/lintian/overrides/
-rw-r--r-- root/root        57 2014-04-28 17:33 ./usr/share/lintian/overrides/libwxgtk-webview3.0-0
drwxr-xr-x root/root         0 2014-04-28 17:33 ./usr/lib/
drwxr-xr-x root/root         0 2014-04-28 17:34 ./usr/lib/x86_64-linux-gnu/
-rw-r--r-- root/root    122608 2014-04-28 17:34 ./usr/lib/x86_64-linux-gnu/libwx_gtk2u_webview-3.0.so.0.0.0
lrwxrwxrwx root/root         0 2014-04-28 17:33 ./usr/lib/x86_64-linux-gnu/libwx_gtk2u_webview-3.0.so.0 -> libwx_gtk2u_webview-3.0.so.0.0.0

$ dpkg -c libwxgtk-webview3.0-0-dbg_3.0.0-3_amd64.deb 
drwxr-xr-x root/root         0 2014-04-28 17:34 ./
drwxr-xr-x root/root         0 2014-04-28 17:34 ./usr/
drwxr-xr-x root/root         0 2014-04-28 17:33 ./usr/share/
drwxr-xr-x root/root         0 2014-04-28 17:33 ./usr/share/doc/
drwxr-xr-x root/root         0 2014-04-28 17:34 ./usr/share/doc/libwxgtk-webview3.0-0-dbg/
-rw-r--r-- root/root     22859 2014-04-28 09:25 ./usr/share/doc/libwxgtk-webview3.0-0-dbg/copyright
-rw-r--r-- root/root     79775 2013-11-11 14:10 ./usr/share/doc/libwxgtk-webview3.0-0-dbg/changelog.gz
-rw-r--r-- root/root     18441 2014-04-28 11:04 ./usr/share/doc/libwxgtk-webview3.0-0-dbg/changelog.Debian.gz
drwxr-xr-x root/root         0 2014-04-28 17:34 ./usr/lib/
drwxr-xr-x root/root         0 2014-04-28 17:34 ./usr/lib/debug/
drwxr-xr-x root/root         0 2014-04-28 17:34 ./usr/lib/debug/.build-id/
drwxr-xr-x root/root         0 2014-04-28 17:34 ./usr/lib/debug/.build-id/a5/
-rw-r--r-- root/root    638129 2014-04-28 17:34 ./usr/lib/debug/.build-id/a5/eafcf1baff67ffc345ddf7927e5a47f28ed8d6.debug

$ dpkg -c libwxgtk-webview3.0-dev_3.0.0-3_amd64.deb
drwxr-xr-x root/root         0 2014-04-28 17:34 ./
drwxr-xr-x root/root         0 2014-04-28 17:33 ./usr/
drwxr-xr-x root/root         0 2014-04-28 17:33 ./usr/share/
drwxr-xr-x root/root         0 2014-04-28 17:33 ./usr/share/doc/
drwxr-xr-x root/root         0 2014-04-28 17:34 ./usr/share/doc/libwxgtk-webview3.0-dev/
-rw-r--r-- root/root     22859 2014-04-28 09:25 ./usr/share/doc/libwxgtk-webview3.0-dev/copyright
-rw-r--r-- root/root     79775 2013-11-11 14:10 ./usr/share/doc/libwxgtk-webview3.0-dev/changelog.gz
-rw-r--r-- root/root     18441 2014-04-28 11:04 ./usr/share/doc/libwxgtk-webview3.0-dev/changelog.Debian.gz
drwxr-xr-x root/root         0 2014-04-28 17:33 ./usr/lib/
drwxr-xr-x root/root         0 2014-04-28 17:33 ./usr/lib/x86_64-linux-gnu/
lrwxrwxrwx root/root         0 2014-04-28 17:33 ./usr/lib/x86_64-linux-gnu/libwx_gtk2u_webview-3.0.so -> libwx_gtk2u_webview-3.0.so.0

there is also the debdiff from the non-new packages, uploaded here http://paste.debian.net/96342/
and attached to this bug report

>>  I also checked the documentation, and updated it.
>> 
> https://github.com/LocutusOfBorg/wx/commit/92a5bd8ff7c2347d00beac74f0938689ce706679
>> 
> https://github.com/LocutusOfBorg/wx/commit/4b357103f85186a8585edb60d0ef6c707dfac5ba
> 
>>  I'm still a little bit worried about the dependencies that I should
>>  add for the new packages, can you please review?
> 
> You shouldn't need to add "libwebkitgtk-3.0-0" manually -
> ${shlibs:Depends} should take care of adding that for you.

Awesome, I wasn't sure about this

> 
> I wouldn't make libwebkitgtk-3.0-0-dbg a hard dependency either (as you
> can definitely do useful debugging with just the wx debug symbols), but
> it might be reasonable to add them as "Suggests:".

changed

> 
>>  I would like to contribute a little more if you want, bumping standard
>>  version, maybe cherry-pick the patch from #736374 or would you like to
>>  wait for the new upcoming release?
> 
> I'm not really sure what's up with the upstream 3.0.1 release.  It seems
> to be have been close for a while, but with about 5 open bugs (just not
> always the same 5), and it's now way past the date on their trac
> milestone for it.
> 
> If we're going to make an upload for this bug, we might as well bundle
> in that patch, plus the one for #746192.
> 
> It looks like no changes are required for policy 3.9.5, so that can be
> bumped too.
> 
Done all, also cherry picked patches from #746192 and #736374

> If you're interested in contributing more generally, you might want to
> consider joining the team: https://alioth.debian.org/projects/freewx/

done


> 
> 
> Cheers,
>     Olly

Really thanks! I'm going to give the package an install shot to see how it goes
(if it doesn't drag any runtime dependency can we avoid the new package?)


Bests,

Gianfranco
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: debdiff.log
Type: text/x-log
Size: 17057 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/freewx-maint/attachments/20140429/f2fe78f2/attachment-0001.bin>

More information about the Freewx-maint mailing list