CUPS patch and request for review

Robert Millan rmh at aybabtu.com
Tue Nov 8 15:51:44 UTC 2005


On Tue, Nov 08, 2005 at 08:53:10AM +0000, Brian M. Carlson wrote:
> I managed to patch CUPS with a fix so that it recognizes FreeBSD devices.  
> Basically, everywhere there was a "defined(__FreeBSD__)" I simply added a "|| 
> defined(__FreeBSD_kernel__)".  Now, I know you are going to say that we are 
> much more like Linux (considering we are using glibc), but in this case CUPS 
> is interested in devices, which we don't share with Linux.  Therefore, I 
> believe the patch is correct.

Sometimes we're more like GNU/Linux, and sometimes we're more like FreeBSD.
Your patch looks very correct to me.

-- 
Robert Millan



More information about the Glibc-bsd-devel mailing list