[Gnuk-users] [GNUK] Nitrokey Start update through regnual

[NIIBE Yutaka]

On 12/02/2016 03:39 AM, Szczepan Zalega | Nitrokey wrote:
> I am sending a group of patches mainly allowing for Nitrokey Start
> firmware update through regnual. The main cause of blocking it was not
> recognizing device by update tool due to different VID/PID used for
> Start device.
> 
> Updated device (1.2->1.2) passes tests from both test/ and tests/
> directories. I have also tested update from Nitrokey Start original
> firmware (1.0.x) to current GNUK 1.2 and it works correctly.
> All checked running under updated Ubuntu 16.10 with GPG2 at version:
> gpg (GnuPG) 2.1.15
> libgcrypt 1.7.2-beta
> GNUK compiled with:
> ./configure --vidpid=20a0:4211 --target=NITROKEY_START
> --enable-factory-reset

Great.  I'll merge.

> I additionally updated submodule URL path to absolute and parse
> GNUK_USB_DEVICE_ID file for supported GNUK devices VIDs and PIDs.
> For easier view you can check [1]. I have not squashed them for easier
> manipulation and better stating purpose of each code change.

The latter is usuful, I'll consider merge.

I'm not sure about the correct way of submodule handling.  My
intention is that it is good to have relative path, in my use cases.
Here are two cases/reasons for relative path.

(1) We have two official repositories at gniibe.org and debian.org.
Those who clone from gniibe.org for Gnuk usually want to use
gniibe.org for Chopstx, too.  And those who clone from debian.org
want to use debian.org for its submodule.

(2) For developers, it is good to encourage having their own
repositories, and not to discourage changes.  With relative path,
software in submodule can also have changes.

Another reason to encourage full copy of repo is that GPL requires
access to complete source code when you distribute binary.


Drawback of this setting of submodule would be those who only want to
touch Gnuk always need to change the relative path to absolute one in
the configuration.
--