[Letsencrypt-devel] Bug#821791: Bug#821791: acme-tiny: Source package includes modified source in .orig.tar.gz

[Jeremías Casteglione]

Hi Tomaž:

Thanks for reporting this!

On Tue, 19 Apr 2016 12:06:17 +0200
Tomaž Šolc <tomaz.solc at tablix.org> wrote:

> Package: acme-tiny
> Version: 20151229-4
> Severity: normal
> 
> Dear Maintainer,
> 
> it appears that acme-tiny source package includes Debian-specific
> modifications in .orig.tar.gz:
> 
> "setup.py" file as packaged does not appear in the upstream
> repository at https://github.com/diafygi/acme-tiny and acme_tiny.py
> appears to be modified as well (__check_deps, __entry_point
> functions).
> 
> These changes should be packaged as quilt patches under
> debian/patches and ..orig.tar.gz should contain unmodified upstream
> source.

When I started to build the package I asked in #d-devel about the best
way to proceed when there wasn't a setup.py provided by upstream; as
py2dsc needs it. It was mentioned there that the best would be to
create one and forward the patches to upstream, and base the package on
the new upstream release including the patches.

I then forked upstream's repo at github and generated a pull request [0]
providing my modifications to create a setup.py file.

 0: https://github.com/diafygi/acme-tiny/pull/86

I started to work on the package then using my fork of upstream's
repo with the setup.py file. Hoping the PR was going to be merged
sometime, but I could start to work in the meantime.

My PR was closed by upstream as duplicate of another PR providing a
setup.py file [1] too. But this PR wasn't merged yet either, so the
package is still based on my fork of upstream repo [2], which doesn't
introduce too many changes either [3].

 1: https://github.com/diafygi/acme-tiny/pull/59
 2: https://github.com/jrmsgit/acme-tiny/tree/jrms/setuptools
 3:
 https://github.com/diafygi/acme-tiny/compare/master...jrmsgit:jrms/setuptools.patch

I'm waiting for upstream to merge any PR providing setuptools
integration, so I create a new release of the package, so until that
happens I think this could be a 'wontfix'.

Cheers,


-- 
Jeremías