[Letsencrypt-devel] Bug#817865: RFS: acmetool/0.0.49 [ITP] -- automatic certificate acquisition tool for Let's Encrypt

[Peter Colberg]

On Sun, May 15, 2016 at 05:39:31PM +0000, Mattia Rizzolo wrote:
> On Sun, May 15, 2016 at 01:30:39PM -0400, Peter Colberg wrote:
> > Please try building acmetool commit fb8b2a5, which disables the
> > OCSP test to avoid network access in the build chroot.
> 
> yeah, that one does build.

Please do a "git fetch" and "git reset --hard origin/master" to fix
a search&replace accident. I promise to never overwrite HEAD again :-(

> Given that you seem to be here, maybe you can double check these lintian
> tags?
> 
> W: acmetool: spelling-error-in-readme-debian acme acme (duplicate word) acme

That is a false positive:

# grep '\<acme acme\>' debian/README.Debian
d /var/run/acme 0755 acme acme - -

> I: acmetool: spelling-error-in-binary usr/bin/acmetool unkown unknown

I searched for this spelling error before in all of the Golang
packages but could not find it, so it must be in the Go standard
library. I will file an upstream issue with golang/go.

> There is also this one, but my guess is that is'a false positive?
> I: acmetool: spelling-error-in-binary usr/bin/acmetool writeN written

Yes, the trailing capital letter is characteristic of a false positive
that I have seen in other packages before.

> Also, I don't know golang, but does the same hardening stuff that you do
> on C/C++ applies here too?  In that case:
> I: acmetool: hardening-no-pie usr/bin/acmetool
> I: acmetool: hardening-no-bindnow usr/bin/acmetool

This is an ongoing issue, please see the following bugs:

https://bugs.debian.org/821454

https://bugs.debian.org/823014

I plan to upload a new version of acmetool once #823014 is fixed.

> PS: I had already pulled and worked too.  I *think* that since some
> debhelper versions where the -O was internally refactored it's not
> strictly needed anymore to carry on the -O in all the overrides.

I will ask the Debian Go maintainers whether -O--buildsystem=golang
can be dropped safely. In any case, it’s fixed in commit 4244a83,
which is ready for upload.

Regards,
Peter