[Letsencrypt-devel] Bug#817865: RFS: acmetool/0.0.49 [ITP] -- automatic certificate acquisition tool for Let's Encrypt

[Mattia Rizzolo]

On Sun, May 15, 2016 at 01:58:28PM -0400, Peter Colberg wrote:
> On Sun, May 15, 2016 at 05:39:31PM +0000, Mattia Rizzolo wrote:
> > On Sun, May 15, 2016 at 01:30:39PM -0400, Peter Colberg wrote:
> > > Please try building acmetool commit fb8b2a5, which disables the
> > > OCSP test to avoid network access in the build chroot.
> > 
> > yeah, that one does build.
> 
> Please do a "git fetch" and "git reset --hard origin/master" to fix
> a search&replace accident. I promise to never overwrite HEAD again :-(

don't worry, I can deal with it ;)
(and already did that, as i received your second email when writing mine
and checked).

BTW, yeah, that's a really bad thing to do in a context like, after you
explicitly asked somebody else to pull... That should have been the
place for a follow up fixup commit :)

> > W: acmetool: spelling-error-in-readme-debian acme acme (duplicate word) acme
> 
> That is a false positive:

I wouldn't mind a override.

> > I: acmetool: spelling-error-in-binary usr/bin/acmetool unkown unknown
> 
> I searched for this spelling error before in all of the Golang
> packages but could not find it, so it must be in the Go standard
> library. I will file an upstream issue with golang/go.

I see.

> > There is also this one, but my guess is that is'a false positive?
> > I: acmetool: spelling-error-in-binary usr/bin/acmetool writeN written
> 
> Yes, the trailing capital letter is characteristic of a false positive
> that I have seen in other packages before.

I wonder if that's another good place for an override and/or a lintian
bug.

> > PS: I had already pulled and worked too.  I *think* that since some
> > debhelper versions where the -O was internally refactored it's not
> > strictly needed anymore to carry on the -O in all the overrides.
> 
> I will ask the Debian Go maintainers whether -O--buildsystem=golang
> can be dropped safely.

ok

> In any case, it’s fixed in commit 4244a83,
> which is ready for upload.

Then, uploaded :)

I also tagged the release in git ^^

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/letsencrypt-devel/attachments/20160515/84a3ac18/attachment.sig>