[Letsencrypt-devel] RFS: python-lecm/0.0.4-1: Let's Encrypt Manager (ITP: #840641)

[Mattia Rizzolo]

On Fri, Oct 21, 2016 at 01:41:25AM +0200, Sebastien Badia wrote:
> On Wed, Oct 19, 2016 at 01:46:06AM (+0200), Sebastien Badia wrote:
> > On Mon, Oct 17, 2016 at 05:40:03PM (+0000), Mattia Rizzolo wrote:
> > > * you are also shipping a binary in /usr/bin; that imho shouldn't be in
> > >   a package named python3-* which usually denotes a library, or anyway
> > >   an application which implementation language matters.
> > >   I do not know lecm, but I'd probably name everything 'lecm', or
> > >   perhaps only the python library in a binary python3-lecm.
> > >   but I'm not sure if what I'm saying makes sense for this case.
> > >   (note that also lintian notices this, with
> > >   library-package-name-for-application)
> > 
> > Yeah! I asked myself the question, and indeed, it's only a binary, so you're
> > right. Should rename also the source package?
> 
> Any comment about this point?

imho, yes too.
It's an application (=> users shouldn't need to care too much about the
implementation language), and upstream's name doesn't contain 'python',
imho there is no reason to specify in the name that it's in python.

> Anyway, I just imported a new release, and  addressed all points mentioned here,
> (thanks for the review!)
> 
> If you want to take a look :)

oh, now I also noticed that the clean target doesn't clean
appropriately.
If you try to rebuild twice the package you get

dpkg-source: info: local changes detected, the modified files are:
 python-lecm-0.0.5/lecm.egg-info/PKG-INFO
 python-lecm-0.0.5/lecm.egg-info/SOURCES.txt
 python-lecm-0.0.5/lecm.egg-info/dependency_links.txt
 python-lecm-0.0.5/lecm.egg-info/entry_points.txt
 python-lecm-0.0.5/lecm.egg-info/requires.txt
 python-lecm-0.0.5/lecm.egg-info/top_level.txt
dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/python-lecm_0.0.5-1.diff.2w_sk2

Also you don't delete debian/lecm.1

You can just add lecm.egg-info and debian/lemc.1 to debian/clean.

You can test this by using pbuilder with the option --twice (though it's
not a comprehensive test, as that just thest that you can build twice
(and you currently can't, that's an RC), but not that you actually
restore the source package to initial situation).

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/letsencrypt-devel/attachments/20161021/f98a299c/attachment-0001.sig>