[Ltrace-devel] [PATCH 6/8] mipsel: Add mips specific symbol info loading
Edgar E. Iglesias
edgar.iglesias at gmail.com
Thu Sep 27 10:09:40 UTC 2012
On Thu, Sep 27, 2012 at 01:31:53AM +0200, Petr Machata wrote:
> edgar.iglesias at gmail.com writes:
> > @@ -131,6 +163,9 @@ arch_elf_init(struct ltelf *lte, struct library *lib)
> > }
...
> > + || breakpoint_init(bp, proc,
> > + (void *) (uintptr_t) libsym->arch.resolved_addr,
>
> The double cast shouldn't be necessary here. uintptr_t already is
> void*, and when we convert it to integral, breakpoint_init will be
> adjusted as well.
Getting back to this, I realized the cast to void * was wrong cause
breakpoint_init want's an arch_addr_t. I've rewritten that specific
part in v2, please take a look at it and see if it looks OK.
Thanks,
Edgar
More information about the Ltrace-devel
mailing list