[Ltrace-devel] [PATCH 6/8] mipsel: Add mips specific symbol info loading

Petr Machata pmachata at redhat.com
Thu Sep 27 11:27:48 UTC 2012

"Edgar E. Iglesias" <edgar.iglesias at gmail.com> writes:

> On Thu, Sep 27, 2012 at 01:31:53AM +0200, Petr Machata wrote:
>> The double cast shouldn't be necessary here.  uintptr_t already is
>> void*, and when we convert it to integral, breakpoint_init will be
>> adjusted as well.
> It seems to be that you have confused uintptr_t with arch_addr_t i your
> response?

Yes indeed.

> The issue in this case is that resolved_addr is a GElf_addr, 64bit integral.
> breakpoint init wants a pointer type, so I need to first transform the
> 64bit intergral value into a 32bit integral value and then cast it to
> t. By using uintptr_t as the intermediate integral type, I think the code
> will be reusable for both 32 and 64 bit mips archs.

Understood, I missed the fact that it's GElf_Addr.

> I've added the same comment at you suggest a bit further down this email,
> it's actually the exact same types being involved.



More information about the Ltrace-devel mailing list