[Ltrace-devel] [PATCH v3] Tracing PLT-less MIPS binaries

Petr Machata pmachata at redhat.com
Mon Feb 9 09:37:38 UTC 2015


Sedat Dilek <sedat.dilek at gmail.com> writes:
> Against which Git branch is this patch?
> pmachata/mips?

That would be the natural choice at this point.

But actually the patch doesn't apply for me as it is.  For some reason
the following hunk is ill-formed:

@@ -406,37 +406,11 @@ arch_elf_add_plt_entry(struct process *proc, struct ltelf *lte,

Curiously, I see the following lines in there:

-	libsym->arch.got_entry_addr = got_entry_addr;
[...]
+	libsym->arch.got_entry_addr = got_entry_addr;

That's not something that diff (or git diff) would produce, I reckon.
Did you craft or edit the patch by hand by any chance?  Could you apply
the changes and rediff please?

Looks good otherwise.

Thanks,
Petr



More information about the Ltrace-devel mailing list