[Ltrace-devel] [PATCH v3] Tracing PLT-less MIPS binaries

Eugene Rudoy gene at freetz.org
Mon Feb 9 11:24:49 UTC 2015


Hi Petr, hi Faraz,

On Mon, Feb 9, 2015 at 10:37 AM, Petr Machata <pmachata at redhat.com> wrote:

> But actually the patch doesn't apply for me as it is.  For some reason
> the following hunk is ill-formed:
>
> That's not something that diff (or git diff) would produce, I reckon.
> Did you craft or edit the patch by hand by any chance?  Could you apply
> the changes and rediff please?
>
I had no problems applying it on top of cf55336f3d. I however had to remove
an extra ")" before "&&" in the following fragment (part of
arch_dynlink_done) in order to get it compiled.

+               if ((got_entry_value != resolved_value)) &&
+                       (got_entry_value != 0)) {

@Faraz: could you please check, if something went wrong and resubmit the
patch if necessary.
I've integrated your patch into the freetz project (s.
http://freetz.org/ticket/2326), had however no time yet to test it. I will
do it in the next couple of days and provide the feedback here. Thanks a
lot for your effort in trying to get it work.

Best regards,
Gene
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/ltrace-devel/attachments/20150209/bea258a5/attachment.html>


More information about the Ltrace-devel mailing list