[Ltrace-devel] [PATCH v3] Fix libunwind support for MIPS

[Petr Machata]

Vicente Olivert Riera <Vincent.Riera at imgtec.com> writes:

> On 24/07/15 08:38, Petr Machata wrote:
>> Vicente Olivert Riera <Vincent.Riera at imgtec.com> writes:
>>
>>>
>>>               rc = unw_get_proc_name(&cursor, fn_name,
>>>                              sizeof(fn_name),
>>> -                           (unw_word_t *) &function_offset);
>>> +                           &uw_function_offset);
>>> +            function_offset = (arch_addr_t) uw_function_offset;
>>> +            assert(uw_function_offset == (unw_word_t) function_offset);
>>> +
>>>               if (rc == 0 || rc == -UNW_ENOMEM)
>>>                   fprintf(options.output, " > %s(%s+%p) [%p]\n",
>>>                       lib_name, fn_name, function_offset, ip);
>>
>> This has the same problem.
>
> Then I don't understand what you mean, Petr. function_offset is not
> evaluated in that if instruction...
>
> Could you please be more explicit?

I think I was talking about that assert, but here you initialize
properly, so it should be OK.

Thanks,
Petr