[Ltrace-devel] [PATCH v5] Fix libunwind support for MIPS

Petr Machata pmachata at gmail.com
Mon Oct 26 17:52:16 UTC 2015


2015-08-06 12:08 GMT+02:00 Vicente Olivert Riera <Vincent.Riera at imgtec.com>:
> Tweak the code to make sure the unwind pointers point to the same
> address as the arch ones.

The patch looks good to me overall.

The one outstanding objection that we have is the one regarding the
runtime overhead of the assert.  But I think that compared to the
per-breakpoint overhead of context switch, it's nothing, so unless
Faraz persuades me otherwise, I'll put this in as is.

(But having information about whether GCC actually can optimize this
out would settle this for good.)

Thanks,
Petr



More information about the Ltrace-devel mailing list