[Net-ssleay-devel] Development Release 1.31_01

[Florian Ragwitz]

On Fri, Jul 06, 2007 at 05:23:38PM +1000, Mike McCauley wrote:
> Hi All,
> 
> On Wednesday 04 July 2007 18:05, Mike McCauley wrote:
> > Hi Florian,
> >
> > Im seeing test failures on Unix and link problems on Windows.
> > Investigating.
> 
> 1. The 'make test' failures were in t/external/08_external.t
> The server at www.cdw.com does not set the SERVER header, and therfore the 
> test was incorrectly reported as failing. Committed a fixed version of 
> 08_exernal.t that looks for CONTENT-TYPE

Thanks.

> There are still a number of tets that are skipped on my Linux platform:
> t/local/01_pod...................skipped
>         all skipped: Test::Pod 1.00 required for testing POD

Install Test::Pod

> t/local/02_pod_coverage..........skipped
>         all skipped: currently disabled

This is disabled as it would fail otherwise due to our bad pod coverage.

> t/local/kwalitee.................skipped
>         all skipped: Needs Test::Kwalitee

Just tests the sanity of the distribution.

> 2. Makefile.PL requires Test::NoWarnings, which is not part of the standard 
> ActiveState ActivePerl 5.8 distro on Windows. 
> This results in a report of Test::NoWarnings being mssing during 'perl 
> Makefile.PL'

OK - Let's just remove the build_requires() calls in Makefile.PL for all
the modules we use conditionally in the test suite (Test::NoWarnings is
one of those).

> 3. There is something wrong with the MakeMaker behaviour under Windows. In 
> inc/Module/Install/PRIVATE/Net/SSLeay.pm, function find_openssl_prefix() the 
> guesses list uis wrong, and should have:
>             'C:\OpenSSL\bin\openssl.exe'     => 'C:\OpenSSL',
> but even after fixing this, the resulting Makefile has the correct Windows INC 
> but incorrect LDLOADLIBS. The right args seem to be passsed to MakeMaker, 
> like this:
> 
> #   MakeMaker Parameters: 
>  #     ABSTRACT => q[Perl extension for using OpenSSL] 
> #     AUTHOR => q[Maintained by Mike McCauley and Florian Ragwitz since 
> November 2005] 
> #     CCCDLFLAGS => q[] 
> #     DIR => [] 
> #     DISTNAME => q[Net-SSLeay] 
> #     INC => q[-IC:\OpenSSL/include -IC:\OpenSSL/inc32 -Iusr/kerberos/include] 
> #     LIBS => q[-LC:\OpenSSL -LC:\OpenSSL/lib -LC:\OpenSSL/out32dll -LC:
> \OpenSSL/lib/VC -llibeay32 -lssleay32] 
> 
> which looks OK, but the Makefile has 
> 
> LDLOADLIBS = "C:\Program Files\Microsoft Visual Studio\VC98\lib\oldnames.lib" 
> "C:\Program Files\Microsoft Visual Studio\VC98\lib\kernel32.lib" "C:\Program 
> Files\Microsoft Visual Studio\VC98\lib\user32.lib" "C:\Program 
> Files\Microsoft Visual Studio\VC98\lib\gdi32.lib" "C:\Program Files\Microsoft 
> Visual Studio\VC98\lib\winspool.lib" "C:\Program Files\Microsoft Visual 
> Studio\VC98\lib\comdlg32.lib" "C:\Program Files\Microsoft Visual 
> Studio\VC98\lib\advapi32.lib" "C:\Program Files\Microsoft Visual 
> Studio\VC98\lib\shell32.lib" "C:\Program Files\Microsoft Visual 
> Studio\VC98\lib\ole32.lib" "C:\Program Files\Microsoft Visual 
> Studio\VC98\lib\oleaut32.lib" "C:\Program Files\Microsoft Visual 
> Studio\VC98\lib\netapi32.lib" "C:\Program Files\Microsoft Visual 
> Studio\VC98\lib\uuid.lib" "C:\Program Files\Microsoft Visual 
> Studio\VC98\lib\ws2_32.lib" "C:\Program Files\Microsoft Visual 
> Studio\VC98\lib\mpr.lib" "C:\Program Files\Microsoft Visual 
> Studio\VC98\lib\winmm.lib" "C:\Program Files\Microsoft Visual 
> Studio\VC98\lib\version.lib" "C:\Program Files\Microsoft Visual 
> Studio\VC98\lib\odbc32.lib" "C:\Program Files\Microsoft Visual 
> Studio\VC98\lib\odbccp32.lib" "C:\Program Files\Microsoft Visual 
> Studio\VC98\lib\msvcrt.lib" 
> 
> ie it looks like LDLOADLIBS does not get the contents of LIBS for windows. 
> Florian, is the right version of all the stuff in inc correct? Im pretty sure 
> this used to work.

Although I'm not a win32 guy I'm pretty sure this used to work. Can you
afford to spend some time on debugging this? I don't have a win32
machine around.


I think we should consider removing auto_include as well. It's pretty
broken anyway and it has no value as we skip tests which need some
external dependency which isn't around anyway.


-Flo

-- 
BOFH excuse #400:
We are Microsoft.  What you are experiencing is not a problem; it is an
undocumented feature.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/net-ssleay-devel/attachments/20070708/e1da0c04/attachment.pgp