[Neurodebian-devel] ANTS

[Yaroslav Halchenko]

On Tue, 25 Feb 2014, Gert Wollny wrote:

> Hello Yaroslav,


> I did a first build, and the list of lintian warnings and errors is
> impressive :(

> A few questions about your state:

> * You override the CFLAGS and  LDFLAGS completely, which results in
> all the  hardening-no-relro lintian warnings. Is there a specific
> reason, otherwise I would just use the Debian default and add the
> -Wl,--as-needed linker flag.

no specific reason -- just legacy from initial packaging, and me never
looking into enabling hardening.  Please go ahead  enabling hardening.
Due to ITK dependency I do not see ants2 being backported far back
for NeuroDebian, thus any way you choose should be fine with me ;)

> * is the -fpermissive really needed? Or is this a leftover from 1.9?

was originally added in

commit 1d6102bbb822b917a891faad58353e8c6911cdb1
Author: Yaroslav Halchenko <debian at onerussian.com>
Date:   Fri May 4 10:31:17 2012 -0400
    BF: patch from Matthias Klosse for gcc 4.7 (Closes: #667099)

not sure if still needed.  build would show ;)

> * the man pages are all created with help2man, right? 

yeap -- the easiest way to produce manpages when none is provided by upstream.

> Because they also give lintian warnings ...

if we could address them -- cool.  if not -- I do not care and consider
illformatted manpage better than none quite often.

> * as for disabling tests on slow archs, I think ITK is currently
> only available for i386 and amd64, test run-time will probably not
> pose a problem.

indeed itk4 is currently available only for x86, but it might come to other
archs eventually.  better to get ready IMHO ;)

> * As for the data, can we just add it in the debian/ directory?
> Since there are binary files, this may violate Debian policy, but
> then again it's data. There seems to be an option to set the test
> data root to avoid downloading.

could go anywhere but I do not see benefits for under debian/ instead of some
directory overlayed over upstream code.  It is upstream data after all, and as
a data collection might even be copyrightable.

-- 
Yaroslav O. Halchenko, Ph.D.
http://neuro.debian.net http://www.pymvpa.org http://www.fail2ban.org
Senior Research Associate,     Psychological and Brain Sciences Dept.
Dartmouth College, 419 Moore Hall, Hinman Box 6207, Hanover, NH 03755
Phone: +1 (603) 646-9834                       Fax: +1 (603) 646-1419
WWW:   http://www.linkedin.com/in/yarik