[newmaint-site] Some patches proposal

[Enrico Zini]

On Sat, Sep 07, 2013 at 12:56:07AM +0200, Marco Bardelli wrote:

> I propose two patches for:
> 
> * Migrate restricted/views.py:advocate_as_dd to use the new
>   backend.email.send_notification, considering that the Log entry with
>   the advocacy is changed_by the advocate, so it contains all needed
>   information to send the mail to debian-newmaint.
> 
> http://anonscm.debian.org/gitweb/?p=users/safanaj-guest/nm2.git;a=commitdiff;h=d81d387a3d1e09f3d20007a89dcb68850889b918
> (templates needs review)
> 
> * When impersonating other people, log entries should be prefixed by a
>   tag like [enrico as ganneff], so that work is credited to the right
>   person
> 
> http://anonscm.debian.org/gitweb/?p=users/safanaj-guest/nm2.git;a=commitdiff;h=d1ca270183f2f8b2c1fe9769fc39ce24e3b7ad09

Thanks! A couple of comments:

> --- a/restricted/templates/restricted/advocate-dd.html
> +++ b/restricted/templates/restricted/advocate-dd.html
> @@ -66,6 +66,10 @@
>      </tr>
>  {% endif %}
>      <tr>
> +        <th>{{form.is_public.label_tag}}:</th>
> +        <td>{{form.is_public}} {{form.is_public.errors}}</td>
> +    </tr>
> +    <tr>
>          <th>{{form.logtext.label_tag}}:</th>
>          <td>{{form.logtext}} {{form.logtext.errors}}</td>
>      </tr>

Advocacy messages are public by default, and the form makes it explicit:

  An email with your advocacy message will be sent to the
  <a href="http://lists.debian.org/debian-newmaint">debian-newmaint</a>
  <em>public</em> mailing list</li>

Can you remove the is_public field from the form, and just save the log
entry with is_public=True?


The other is in:

> +++ b/templates/notification_mails/advocacy_as_dd.txt
> @@ -0,0 +1,14 @@
> +{% load nm %}
> +From: {{ log.changed_by.fullname }} via nm <{{ log.changed_by.email }}>

It should be "{{ log.changed_by.preferred_email }}" instead, so the from
will thave the @debian.org addresses. Besides that, the template looks
good.


I look forward to pulling and deploying the lot.


Ciao,

Enrico

-- 
GPG key: 4096R/E7AD5568 2009-05-08 Enrico Zini <enrico at enricozini.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/newmaint-site/attachments/20130912/dc6e7d26/attachment.sig>