[newmaint-site] Some patches proposal

[Marco Bardelli]

Enrico Zini <enrico at enricozini.org> writes:

> On Sat, Sep 07, 2013 at 12:56:07AM +0200, Marco Bardelli wrote:
>
>>[... skip ...]
>
> Thanks! A couple of comments:
Thanks to you.
>
>> --- a/restricted/templates/restricted/advocate-dd.html
>> +++ b/restricted/templates/restricted/advocate-dd.html
>> @@ -66,6 +66,10 @@
>>      </tr>
>>  {% endif %}
>>      <tr>
>> +        <th>{{form.is_public.label_tag}}:</th>
>> +        <td>{{form.is_public}} {{form.is_public.errors}}</td>
>> +    </tr>
>> +    <tr>
>>          <th>{{form.logtext.label_tag}}:</th>
>>          <td>{{form.logtext}} {{form.logtext.errors}}</td>
>>      </tr>
>
> Advocacy messages are public by default, and the form makes it explicit:
>
>   An email with your advocacy message will be sent to the
>   <a href="http://lists.debian.org/debian-newmaint">debian-newmaint</a>
>   <em>public</em> mailing list</li>
>
> Can you remove the is_public field from the form, and just save the log
> entry with is_public=True?
>
>
> The other is in:
>
>> +++ b/templates/notification_mails/advocacy_as_dd.txt
>> @@ -0,0 +1,14 @@
>> +{% load nm %}
>> +From: {{ log.changed_by.fullname }} via nm <{{ log.changed_by.email }}>
>
> It should be "{{ log.changed_by.preferred_email }}" instead, so the from
> will thave the @debian.org addresses. Besides that, the template looks
> good.

I fixed both issues in a "re-new rebased" commit at:
http://anonscm.debian.org/gitweb/?p=users/safanaj-guest/nm2.git;a=commitdiff;h=3f757d36e00feb378a57cd790d79681ffb566309

Probably this commit could be cherry-picked only after the previous one for
impersonating issue at:
http://anonscm.debian.org/gitweb/?p=users/safanaj-guest/nm2.git;a=commitdiff;h=c4e432364f23c26bd1413bd1c7cab7203b3cd7e1

>
>
> I look forward to pulling and deploying the lot.
>
both commits are on my personal branch emails_advocate_as_dd.

I'm thinking to work on:
* Allow advocates to edit personal information of people in active
  processes advocated by them

soon for news.

>
> Ciao,
> Enrico
Ciao,
Marco
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/newmaint-site/attachments/20130912/0a2b1975/attachment.sig>