[PKG-OpenRC-Debian] Bug#840073: Bug: #840073 Patch to fix upgrade from jessie to stretch/testing

[Adam Borowski]

On Tue, Nov 08, 2016 at 07:14:12PM +0100, Svante Signell wrote:
> Hi,
> 
> looking at the problem and setting up piuparts, and using a local repository, I
> think the problem with upgrade from jessie to stretch/sid is solved with the
> attached patch.
> 
> The following has been tested:
>  * upgrade from stretch (0.21-3) to sid (0.21-4)
>  * upgrade from jessie (0.13.1-4) to sid (0.21-4)
>  * upgrade from kessie (0.13.1-4) to stretch/testing (0.21-4)
> piuparts logs are available on request.
> 
> I need somebody doing an upload of the new package, of course modifying the
> changelog accordingly: Adam/Benda?

I'm uncomfortable applying patches I don't fully understand, but as Benda
is still busy, I guess I need to if the package is supposed to be in shape
for stretch -- the freeze is close.

> +++ openrc-0.21/debian/openrc.preinst	2016-11-08 18:24:06.579859726 +0100
> @@ -0,0 +1,27 @@
> +# Remove a no-longer used conffile

> +case "$1" in
> +install|upgrade)
> +    if dpkg --compare-versions "$2" le "$LASTVERSION"; then
> +        rm_conffile openrc "/etc/pkg/conf.1"
> +        rm_conffile openrc "/etc/pkg/conf.2"
> +    fi
> +esac

You failed to fill in the placeholders: $LASTVERSION is "", /etc/pkg/conf.1
and /etc/pkg/conf.2 don't exist.  Thus, /etc/init.d/transit doesn't get
removed -- your tests succeeded only because leaving a dangling but owned
conffile isn't a fatal error.


Meow!
-- 
A true bird-watcher waves his tail while doing so.