[PKG-OpenRC-Debian] Bug#840073: Bug: #840073 Patch to fix upgrade from jessie to stretch/testing

[Svante Signell]

On Tue, 2016-11-15 at 01:08 +0100, Adam Borowski wrote:
> On Tue, Nov 08, 2016 at 07:14:12PM +0100, Svante Signell wrote:
> > 
> > +++ openrc-0.21/debian/openrc.preinst	2016-11-08 18:24:06.579859726
> > +0100
> > @@ -0,0 +1,27 @@
> > +# Remove a no-longer used conffile
> > 
> > +case "$1" in
> > +install|upgrade)
> > +    if dpkg --compare-versions "$2" le "$LASTVERSION"; then
> > +        rm_conffile openrc "/etc/pkg/conf.1"
> > +        rm_conffile openrc "/etc/pkg/conf.2"
> > +    fi
> > +esac
> You failed to fill in the placeholders: $LASTVERSION is "", /etc/pkg/conf.1
> and /etc/pkg/conf.2 don't exist.  Thus, /etc/init.d/transit doesn't get
> removed -- your tests succeeded only because leaving a dangling but owned
> conffile isn't a fatal error.

Thanks for fixing this, and other stuff in that script. I admit that the code
above was strange, I got it from https://wiki.debian.org/DpkgConffileHandling wh
ich maybe should be updated.
Of course either LASTVERSION has to be set, or be hardcoded as you did, and the
right conffile be removed.