[PKG-Openstack-devel] Bug#910011: python-oslo.vmware: Please remove unnecessary overrides

[Chris Lamb]

Source: python-oslo.vmware
Version: 2.31.0-2
Severity: normal
Tags: patch

Hi,

The debian/rules file appears to include a suspiciously high number of
dh_override_-style overrides.

It is likely that is this was intended to optimise package builds by
introducing "no-op" overrides that avoid specific debhelper commands.

However, whilst using overrides are not a problem per-se, such a list
is usually a premature optimisation, subject to constant revision,
prevents future debhelper versions fixing archive-wide problems, adds
unnecessary noise/distraction for anyone reviewing the package,
increases the package's "bus factor" and is typically a premature
optimisation. It is, in addition, aesthetically displeasing.

Please remove the unnecessary overrides. A patch is attached.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
diff --git a/debian/rules b/debian/rules
index fd11a20..8e10b2b 100755
--- a/debian/rules
+++ b/debian/rules
@@ -25,13 +25,3 @@ endif
 override_dh_sphinxdoc:
 	PYTHONPATH=. PYTHON=python3 python3 -m sphinx -b html doc/source debian/python-oslo.vmware-doc/usr/share/doc/python-oslo.vmware-doc/html
 	dh_sphinxdoc -O--buildsystem=python_distutils
-
-# Commands not to run
-override_dh_installcatalogs:
-override_dh_installemacsen override_dh_installifupdown:
-override_dh_installinfo override_dh_installmenu override_dh_installmime:
-override_dh_installmodules override_dh_installlogcheck:
-override_dh_installpam override_dh_installppp override_dh_installudev override_dh_installwm:
-override_dh_installxfonts override_dh_gconf override_dh_icons override_dh_perl override_dh_usrlocal:
-override_dh_installcron override_dh_installdebconf:
-override_dh_installlogrotate override_dh_installgsettings: