[PKG-Openstack-devel] Bug#910012: python3-antlr3: Please remove unnecessary overrides

[Chris Lamb]

Source: python3-antlr3
Version: 3.5.2-5
Severity: normal
Tags: patch

Hi,

Hi,

The debian/rules file appears to include a suspiciously high number of
dh_override_-style overrides.

It is likely that is this was intended to optimise package builds by
introducing "no-op" overrides that avoid specific debhelper commands.

However, whilst using overrides are not a problem per-se, such a list
is usually a premature optimisation, subject to constant revision,
prevents future debhelper versions fixing archive-wide problems, adds
unnecessary noise/distraction for anyone reviewing the package,
increases the package's "bus factor" and is typically a premature
optimisation. It is, in addition, aesthetically displeasing.

Please remove the unnecessary overrides. A patch is attached.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
diff --git a/debian/rules b/debian/rules
index 107c572..9ef1eeb 100755
--- a/debian/rules
+++ b/debian/rules
@@ -31,13 +31,3 @@ override_dh_auto_clean:
 override_dh_clean:
 	dh_clean
 	rm -rf build
-
-# Commands not to run
-override_dh_installcatalogs:
-override_dh_installemacsen override_dh_installifupdown:
-override_dh_installinfo override_dh_installmenu override_dh_installmime:
-override_dh_installmodules override_dh_installlogcheck:
-override_dh_installpam override_dh_installppp override_dh_installudev override_dh_installwm:
-override_dh_installxfonts override_dh_gconf override_dh_icons override_dh_perl override_dh_usrlocal:
-override_dh_installcron override_dh_installdebconf:
-override_dh_installlogrotate override_dh_installgsettings: