ignoring "group is not maintainer"

[Joachim Breitner]

Hi,

Am Freitag, den 26.02.2010, 23:32 +0100 schrieb Martín Ferrari:
> 2010/2/21 Joachim Breitner <nomeata at debian.org>:
> > Especially the name_mismatch and archive_foreign lines should be
> > interesting for you.
> 
> I have just commited a change that does what lucas was asking for,
> although implemented differently. Anyway, I'm confused by your diff,
> it seems to ignore a lot of other stuff. In particuar, archive_foreign
> is when the group is not mentioned at all in debian/control,

this is desired, we do some „service hosting“ for packages that are
officially  not team maintained (such as darcs).

>  and name_mismatch is when the package name doesn't match the repository
> name...

I might have done that accidentally while trying to comment out the
archive_foreign hint. I’ll re-enable that again, to reduce the diff.

> > Having this categorization stuff more configurable would be nice,
> > though. Especially as ATM (unless I read it wrong) the logic is partly
> > in the perl files and partly in the templates.
> 
> In the templates should be no logic (ideally), at least not for
> classification. Please point me out where you have seen some
> clasification logic on it, it should not be there.

I might be misunderstanding the code, but this part of
templates/by_category seems to be interacting with the perl code:

<table id="main_table">
    [% INCLUDE section data=data list=with_rc_bugs name="with_rc_bugs"
title="With RC bugs" %]
    [% INCLUDE section data=data list=for_upload name="for_upload"
title="Ready for upload" %]
    [% INCLUDE section data=data list=tagged name="tagged" title="Tagged
but not in the archive (yet)" %]
    [% INCLUDE section data=data list=incoming name="incoming"
title="NEW and incoming" %]
    [% INCLUDE section data=data list=weird name="weird" title="Packages
with strange versions in the repository" %]
    [% INCLUDE section data=data list=itp_wip name="itp_wip" title="New
packages :: Work in progress" %]
    [% INCLUDE section data=data list=wip name="wip" title="Work in
progress" %]
    [% INCLUDE section data=data list=waiting name="waiting"
title="Waiting for other packages" %]
    [% INCLUDE section data=data list=ignore_wip name="ignore_wip"
title="Work in progress :: No need to upload" %]
    [% # INCLUDE section data=data list=with_bugs name="with_bugs"
title="With bugs" %]
    [% # INCLUDE section data=data list=for_upgrade name="for_upgrade"
title="Newer upstream release available" %]
    [% # INCLUDE section data=data list=upgrade_wip name="upgrade_wip"
title="Newer upstream available :: Work in progress" %]
    [% INCLUDE section data=data list=all name='unclassified'
title='Unclassified' %]
</table>

at least if one wants the user’s assumptions fulfilled that a package
appears in the first visible list, and one changes some categorizations,
then one has to make sure this matches.

I guess I can undo the commenting here for categories that I don’t want
to use in my instance, as they will be empty.

But I wonder if it were not cleaner if the list of categories is defined
in pet.cgi, where they are filled. Maybe not separate lists, but rather
a list of category names with entries. This would also remove the
additional duplication here at pet.cgi:

                all         => \@no_prob,
                for_upgrade => \@for_upgrade,
                upgrade_wip => \@upgrade_wip,
                weird       => \@weird,
                for_upload  => \@for_upload,
                incoming    => \@incoming,
                tagged      => \@tagged,
                itp_wip     => \@itp_wip,
                wip         => \@wip,
                with_bugs   => \@with_bugs,
                with_rc_bugs=> \@with_rc_bugs,
                ignore_wip  => \@ignore_wip,
                waiting     => \@waiting,

Just some ideas...

Greetings,
Joachim

-- 
Joachim "nomeata" Breitner
Debian Developer
  nomeata at debian.org | ICQ# 74513189 | GPG-Keyid: 4743206C
  JID: nomeata at joachim-breitner.de | http://people.debian.org/~nomeata
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Dies ist ein digital signierter Nachrichtenteil
URL: <http://lists.alioth.debian.org/pipermail/pet-devel/attachments/20100227/18532f11/attachment.pgp>