[Pkg-ace-devel] Bug#825709: ace: please make it build on kfreebsd again

[Mattia Rizzolo]

On Mon, Jun 20, 2016 at 09:39:02PM +0200, Pau Garcia i Quiles wrote:
> What do you mean?

* overrided extended-description-is-probably-too-short
* very long but not wrap-and-sort'ed Build-Depends line
* the tarball *adds* some files, when compared against the one I can
  download named ACE+TAO-src-6.3.4.tar.gz (why using the +TAO and then
  remove it all? (mind you: I don't even have a clue about what's that)
  I didn't dare to check whether there were even modified files…
* repackaging done with a made up script, instead of nowadays-standard
  Files-Excluded line in d/copyright
* I don't want to check yet another time, but that configure thing in
  d/rules looks a bit fishy.  what does dh_auto_configure do then?  if
  nothing, cool, but then why haven't you override it?  if something, it
  would be run before that configure target so I still wonder what's the
  point.
* you haven't updated d/copyright in this upload, and year passed, and
  I'd guess there would be some copyright holders that holds a copyright
  till 2016 too.
* there is an UNRELEASED entry in changelog
* no dep5 copyright, but you're near, so why not finish it?
* there are patch with Last-Update: 2010 but are not forwarded yet.
* there are a couple of nowadays uneeded lintian overrides


then tiny parts here and there.  I see how this is a big package, and I
see it doesn't have a conventional build system, so I kinda see why it's
in this state, but not really, as it doesn't require so much
maintenance, and the team doesn't have so many packages to take care of,
so some more care at little details wouldn't really harm.

But what makes me uneasy is the tarball thing, the rest I can very well
close an eye and live pretty fine (but I'm usually much more picky).

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-ace-devel/attachments/20160620/6151f083/attachment.sig>