[Pkg-bluetooth-discuss] RFS: gnome-phone-manager

[Mario Iseli]

On Tue, Aug 21, 2007 at 11:01:26AM +0200, Francesco Namuri wrote:
> Hi Mario,
> are you italian? because I'm italian, we can speak in italian... :)

Hi Francesco,
no, I'm from Switzerland and my grandmother is Italian, due to her I
finally got an Italian name. But i don't speak Italian unfortunately, so
english is much better ;)

[snip-all-the-rest-of-your-mail]

debian/changelog:
Can you just make one entry? I recommend you to do that because then the
changelog is really "the exact history" as it is in Debian. I don't
force you to do it, it's technically ok. But ehm, if you will to it
please change that:
 * Initial release. (Closes: #401171: ITP: gnome-phone-manager --
   control aspects of your mobile phone from your GNOME 2 desktop -
   Debian Bug report logs)

 * Initial release (Closes: #401171). <- would be enough :)

(at the end of the file is a useless empty line by the way)

debian/control:
Good job here, but a useless space character at the end of "-Evolution
Addressbook integration", if you use vim to edit the files add the
following snippet to your .vimrc, then you will see what I mean. :)
sy on
highlight WhitespaceEOL ctermbg=red guibg=red
match WhitespaceEOL /\s\+$/

debian/copyright:
There is one person mentioned in AUTHORS and not in debian/copyright.
Please fix that... I do also see many sourcefiles which have no headers
with copyright statements. Is it somewhere written that those files are
GPL? Wherefrom do you assume that they are?
(there are also many whitespaces in the file :))

The rest looks really ok, you did a good job. Filippo Giunchedi told me
that he still hasn't got your request to join pkg-bluetooth on alioth.
If you want to join us, please do so and import this package into SVN.
I'm also ready to help on irc.debian.org/#debian-bluetooth (Nick: tiCo)

Regards and thanks for your work,

-- 
  .''`.     Mario Iseli <mario at debian.org>
 : :'  :    Debian GNU/Linux developer
 `. `'`
   `-  Debian - when you have better things to do than fixing a system
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-bluetooth-discuss/attachments/20070821/157d55ab/attachment.pgp