[Pkg-bluetooth-discuss] RFS: gnome-phone-manager

[Francesco Namuri]

Il giorno mar, 21/08/2007 alle 11.58 +0200, Mario Iseli ha scritto:
> On Tue, Aug 21, 2007 at 11:01:26AM +0200, Francesco Namuri wrote:
> > Hi Mario,
> > are you italian? because I'm italian, we can speak in italian... :)
> 
> Hi Francesco,
> no, I'm from Switzerland and my grandmother is Italian, due to her I
> finally got an Italian name. But i don't speak Italian unfortunately, so
> english is much better ;)

Hi Mario,
ok, speak in english, sorry for mine, I know, it's terrible... :)

> debian/changelog:
> Can you just make one entry? I recommend you to do that because then the
> changelog is really "the exact history" as it is in Debian. I don't
> force you to do it, it's technically ok. But ehm, if you will to it
> please change that:
>  * Initial release. (Closes: #401171: ITP: gnome-phone-manager --
>    control aspects of your mobile phone from your GNOME 2 desktop -
>    Debian Bug report logs)
> 
>  * Initial release (Closes: #401171). <- would be enough :)
> 
> (at the end of the file is a useless empty line by the way)

Corrected the empty line, but If you agree I prefer to maintain all the
changelog entries, yesterday I had a bad discussion about this with a
co-maintaner of another package about this. :) In mentors some weeks ago
we speak about this problem and I agreed with with the "philosophy"
to maintain all changelog entries, also of the revisions that are not
uploaded in debian... (and there is also the point that, uploading many times
the same revision to mentors, can create problems)
 
> debian/control:
> Good job here, but a useless space character at the end of "-Evolution
> Addressbook integration", if you use vim to edit the files add the
> following snippet to your .vimrc, then you will see what I mean. :)
> sy on
> highlight WhitespaceEOL ctermbg=red guibg=red
> match WhitespaceEOL /\s\+$/

Fixed, thanks for the hint for vi.

> debian/copyright:
> There is one person mentioned in AUTHORS and not in debian/copyright.
> Please fix that... I do also see many sourcefiles which have no headers
> with copyright statements. Is it somewhere written that those files are
> GPL? Wherefrom do you assume that they are?
> (there are also many whitespaces in the file :))

fixed all, authors issue and whitespaces... :)
about the sourcefiles, I presume that they are GPL, the first
implementation was written by Edd Dumbill (a debian developper, he's
also a gnome contributor), I know these are only supposition... :)
If you think I write to the current author or directly to Edd...

> The rest looks really ok, you did a good job. Filippo Giunchedi told me
> that he still hasn't got your request to join pkg-bluetooth on alioth.
> If you want to join us, please do so and import this package into SVN.
> I'm also ready to help on irc.debian.org/#debian-bluetooth (Nick: tiCo)

I'll make the request after this mail...

> Regards and thanks for your work,
thanks to you for your review.

I've uploaded the fixed version to:
http://mentors.debian.net/debian/pool/main/g/gnome-phone-manager/gnome-phone-manager_0.10-2.dsc

cheers,
francesco

-- 
Francesco Namuri
francesco(at)namuri(dot)it   http://namuri.it/
id gpg key: 21A4702A         accipiter at jabber.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Questa =?ISO-8859-1?Q?=E8?= una parte del messaggio
	firmata digitalmente
Url : http://lists.alioth.debian.org/pipermail/pkg-bluetooth-discuss/attachments/20070821/3fd9c03c/attachment.pgp