[Pkg-dkms-maint] dkms 2.0.21.1-1

[Giuseppe Iuculano]

Ben Hutchings ha scritto:
>> dkms (2.0.21.1-1) unstable; urgency=low
>>
>>   * [bcda131] Imported Upstream version 2.0.21.1
>>   * [487ad26] debian/patches/13-template.patch:
>>     Updated template-dkms-mkdeb Changes:
>>     - Bump to debhelper 7 compatibility levels
>>     - Updated to standards version 3.8.0
> [...]
> 
> It actually claims version 3.8.1 now.

Yes, new changelog is:


dkms (2.0.21.1-1) unstable; urgency=low

  * [bcda131] Imported Upstream version 2.0.21.1
  * [487ad26] debian/patches/13-template.patch:
    Updated template-dkms-mkdeb Changes:
    - Bump to debhelper 7 compatibility levels
    - Updated to standards version 3.8.1
    - Use Dynamic Kernel Modules Support Team as maintainer field
    - Remove bash and add ${misc:Depends} in Depends
    - Use dh_prep instead of dh_clean -k
  * [c75e860] Updated to standards version 3.8.1 (No changes needed)
  * [0d14f3e] Update dkms to check for /etc/modprobe.d/dkms.conf,
    dh_installmodules now gives files in /etc/modprobe.d a .conf syntax,
    as required by new module-init-tools.
  * [ceff6d3] Move to kernel section as by ftpmasters override
  * [aa84c76] debian/control: Fix VCS-Browser field
  * [6cd45ec] debian/patches/15_modprobe.patch: Do not install
    /etc/modprobe.d/dkms, it only contains comments and is opened and
    parsed every time modprobe is run (and it is run very often at boot
    time). Use instead (and create if necessary)
    /etc/modprobe.d/package_name.conf. (Closes: #525379)
  * [171907c] debian/postinst: if /etc/modprobe.d/dkms is modified, put
    its content in /etc/modprobe.d/dkms.conf and remove it.
  * [426868b] update debian/copyright to add Giuseppe Iuculano to
    copyright on debian/*
  * [1ffb2cd] Removed 03-use-new-header_postinst.d_directory.patch,
    /etc/kernel/header_postinst.d is used only by kernel-package. dkms
    must use /etc/kernel/postinst.d/ directory.
  * [eff2f3e] debian/control: demoted linux-headers and linux-image in
    Recommends, removed kernel-package and build-essential from Depends,
    and added only gcc.
  * [508c115] debian/postinst: Remove also
    /etc/kernel/header_postinst.d/dkms and do an init script remove to
    un-do the "bad" links created by previous version

  [ Mario Limonciello ]
  * [848d7f9] update debian/copyright to add Mario Limonciello to
    copyright on debian/*
  * [791fc37] Update debian/rules to only run DKMS on the startup
    targets. This change was proposed from Ubuntu some time back as DKMS
    doesn't do anything on shutdown.


> 
> Also I think the postinst addition needs some changes:
> 
>> 	if dpkg --compare-versions "$2" lt-nl "2.0.21.1-1" ; then
> 
> To allow for backporting, it might be better to add a "~" on the end of
> the version you compare with.

Fixed.

> 
>> 		if [ -e "/etc/modprobe.d/dkms" ]; then
>> 			if [ "`md5sum \"/etc/modprobe.d/dkms\" | sed -e \"s/ .*//\"`" = \
>> 				"`dpkg-query -W -f='${Conffiles}' dkms | sed -n -e \"\\\\' /etc/modprobe.d/dkms's/.* //p\"`" ]
> 
> Using backticks here means you have to do a lot of escaping and the
> result is really hard to understand.  It would be more readable if you
> used $() and variables, as in the examples at
> <http://wiki.debian.org/DpkgConffileHandling>.

Fixed, I also added a remove for /etc/kernel/header_postinst.d/dkms

>> 			then
>> 				rm -f "/etc/modprobe.d/dkms"
>> 			fi
>> 		else
>> 			echo "Moving /etc/modprobe.d/dkms to /etc/modprobe.d/dkms.conf"
>> 			grep -v '^#' /etc/modprobe.d/dkms >> /etc/modprobe.d/dkms.conf
> 
> Why remove comments?

Because dkms didn't add comments when inserted a module in /etc/modprobe.d/dkms
(now it uses /etc/modprobe.d/package_name.conf, 15_modprobe.patch), so without
removing them we will get only some duplicated comments.

Uploaded again on mentors.

Cheers,
Giuseppe.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-dkms-maint/attachments/20090503/438ff6a7/attachment.pgp>