[Pkg-dkms-maint] dkms 2.0.21.1-1

[Ben Hutchings]

On Sun, 2009-05-03 at 21:39 +0200, Giuseppe Iuculano wrote:
[...]
>   * [eff2f3e] debian/control: demoted linux-headers and linux-image in
>     Recommends, removed kernel-package and build-essential from Depends,
>     and added only gcc.

I'm not sure about this recommendation:

    linux-headers-2.6-486 | linux-headers-generic | linux-headers

linux-headers-2.6-486 is only available on i386 and is not the flavour
that most users will have installed.  We could really use a metapackage
like linux-headers-2.6-all which would pull in the headers for all
flavours of the current default kernel version.  Until then, I think the
recommendation should be:

    linux-headers-2.6-686 [i386] | linux-headers-2.6-amd64 [amd64] | linux-headers

and in Ubuntu:

    linux-headers-generic [i386, amd64] | linux-headers

which should DTRT for the majority of users.

[...]
> >> 			then
> >> 				rm -f "/etc/modprobe.d/dkms"
> >> 			fi
> >> 		else
> >> 			echo "Moving /etc/modprobe.d/dkms to /etc/modprobe.d/dkms.conf"
> >> 			grep -v '^#' /etc/modprobe.d/dkms >> /etc/modprobe.d/dkms.conf
> > 
> > Why remove comments?
> 
> Because dkms didn't add comments when inserted a module in /etc/modprobe.d/dkms
> (now it uses /etc/modprobe.d/package_name.conf, 15_modprobe.patch), so without
> removing them we will get only some duplicated comments.

But what if the user added comments?

(If these files are not supposed to be edited by the administrator then
they should be created under /var/lib and symlinked into
/etc/modprobe.d.  But it is probably better to assume that the
administrator will edit them.)

> Uploaded again on mentors.

I'm actually reading your changes through the git log, so don't feel you
need to do that.

Ben.

-- 
Ben Hutchings
No political challenge can be met by shopping. - George Monbiot
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/pkg-dkms-maint/attachments/20090503/9d2a6900/attachment.pgp>