[Pkg-dkms-maint] Bug#832558: Fix dkms mkdeb / mkdsc / mkbmdeb

[Mario.Limonciello at dell.com]

Pierre,

There have been a few times the patches got synced between the two, but I'll admit
I don't know the current home to the patches that live in the Debian package.

Hopefully some of the Debian maintainers can speak up since I haven't tracked it.

I think it would be good to make sure that all patches that are currently in 2.3 in Debian
are no longer applicable in 2.5 and then update to 2.5 in Debian as well.

Thanks,

> -----Original Message-----
> From: Pierre Neyron [mailto:pierre.neyron at free.fr]
> Sent: Monday, February 12, 2018 11:54 AM
> To: Limonciello, Mario <Mario_Limonciello at Dell.com>; 832558 at bugs.debian.org;
> pkg-dkms-maint at lists.alioth.debian.org
> Subject: Re: [Pkg-dkms-maint] Bug#832558: Fix dkms mkdeb / mkdsc / mkbmdeb
> 
> Hi Marco,
> 
> Problem is Debian dkms (v2.3) seems to be an old fork of github/dell
> dkms (v2.5). Support for mkbmdeb comes from a patch in the Debian
> package but does not exist upstream. As a result my patch is not so
> relevant for upstream.
> 
> Do you know if the current Debian patches were already proposed to
> upstream ? Do you know the roadmap for a possible merge from upstream
> (bump Debian package version to 2.5) ?
> 
> Last be not least, since I do not have all the test cases in mind, I'd
> be glad to get a review from the Debian maintainers before sending upstream.
> 
> 
> Thanks,
> Best regards,
> Pierre
> 
> On 02/12/2018 06:27 PM, Mario.Limonciello at dell.com wrote:
> >> -----Original Message-----
> >> From: Pkg-dkms-maint [mailto:pkg-dkms-maint-
> >> bounces+mario_limonciello=dell.com at lists.alioth.debian.org] On Behalf Of
> Pierre
> >> Neyron
> >> Sent: Monday, February 12, 2018 11:21 AM
> >> To: 832558 at bugs.debian.org
> >> Subject: [Pkg-dkms-maint] Bug#832558: Fix dkms mkdeb / mkdsc / mkbmdeb
> >>
> >> Please find attached a patch for the dkms script (package version 2.3-3)
> >> that fixes the following issues:
> >>
> >> - fix mkdeb (1): mkdeb failed because a mv command was looking for a
> >> package filename with -${debian_build_arch} instead of -all.
> >>
> >> - fix mkdeb (2): allow creating a dkms package without requiring to
> >> build the binary module beforehand . The patch actually makes
> >> --source-only de facto for mkdeb and mkdsc.
> >>
> >> - fix mkbmdeb: make --binary-only de facto for mkbmdeb
> >>
> >> - fix usage: lacked mkdsc
> >>
> >> Regards
> >> Pierre
> >
> > Pierre,
> >
> > Can you please submit the patches to upstream at github?
> >