[Pkg-dns-devel] Bug#852297: dnssec-trigger: Installs config files directly in the root of the filesystem

[Axel Beckert]

Hi,

Guus Sliepen wrote:
> It appears the dnssec-trigger package installs the following files
> directly in the root:
> 
> -rw-r--r-- root/root       215 2016-12-22 12:01 ./dnssec-triggerd-keygen.service
> -rw-r--r-- root/root       573 2016-12-22 12:01 ./dnssec-triggerd.service
> -rw-r--r-- root/root      4640 2016-12-22 12:01 ./dnssec.conf 

I see that here, too. And it's not a problem in the maintainer scripts
but in the contents of the package:

→ dpkg -L dnssec-trigger
/.
/dnssec-triggerd-keygen.service
/dnssec-triggerd.service
/dnssec.conf
/etc
[…]

> This looks like a bug to me, in any case it would be a violation of the
> FHS.

Definitely both. It was introduced in 0.13-3 as 0.13-2 doesn't show
that issue:

→ dpkg-deb --contents dnssec-trigger_0.13-2_amd64.deb | egrep 'dnssec\.conf|\.service'
-rw-r--r-- root/root      4640 2016-12-22 10:23 ./etc/dnssec-trigger/dnssec.conf
-rw-r--r-- root/root       254 2016-12-22 10:23 ./lib/systemd/system/dnssec-triggerd-keygen.service
-rw-r--r-- root/root       573 2016-12-22 10:23 ./lib/systemd/system/dnssec-triggerd.service

Just from looking at it, it's though unclear which of the two commits
(or maybe both together) is really the culprit here:

https://anonscm.debian.org/git/pkg-dns/dnssec-trigger.git/commit/?id=ca6b92b9b0c5ded050ce0e221f75471ee7db413c
https://anonscm.debian.org/git/pkg-dns/dnssec-trigger.git/commit/?id=23127353f8396e58cbcc344122ca20b2fa706c9e

The fact that quilt patches were renamed doesn't make the review of
the diffs easier. :-/

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe at debian.org>, http://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE