[Pkg-dns-devel] Bug#852297: Bug#852297: dnssec-trigger: Installs config files directly in the root of the filesystem

[Ondřej Surý]

Hi Axel and Guus,

I have fixed the error (upstream is using autoconf but not automake) by
adding

systemdsystemunitdir=@systemdsystemunitdir@

into Makefile.in.

Anyway could somebody else fill an unblock on release.debian.org, as my
reportbug
is broken right now:

Submit this report on release.debian.org (e to edit)
[Y|n|a|c|e|i|l|m|p|q|d|t|s|?]? 
Passing message to gpg for signature...
text/x-diff; charset=utf-8

text/plain; charset=utf-8

application/x-xz; charset=binary

Traceback (most recent call last):
  File "/usr/bin/reportbug", line 2233, in <module>
    main()
  File "/usr/bin/reportbug", line 1107, in main
    return iface.user_interface()
  File "/usr/bin/reportbug", line 2224, in user_interface
    self.options.envelopefrom)
  File "/usr/lib/python3/dist-packages/reportbug/submit.py", line 209,
  in send_report
    (message, failed) = mime_attach(body, attachments, charset,
    body_charset)
  File "/usr/lib/python3/dist-packages/reportbug/submit.py", line 177,
  in mime_attach
    email.Encoders.encode_base64(part)
AttributeError: module 'email' has no attribute 'Encoders'

And I am hoping on AMS-IAD plane in ~10 minutes.

Cheers,
-- 
Ondřej Surý <ondrej at sury.org>
Knot DNS (https://www.knot-dns.cz/) – a high-performance DNS server
Knot Resolver (https://www.knot-resolver.cz/) – secure, privacy-aware,
fast DNS(SEC) resolver
Vše pro chleba (https://vseprochleba.cz) – Mouky ze mlýna a potřeby pro
pečení chleba všeho druhu

On Tue, Jan 31, 2017, at 08:27, Axel Beckert wrote:
> Hi,
> 
> Guus Sliepen wrote:
> > It appears the dnssec-trigger package installs the following files
> > directly in the root:
> > 
> > -rw-r--r-- root/root       215 2016-12-22 12:01 ./dnssec-triggerd-keygen.service
> > -rw-r--r-- root/root       573 2016-12-22 12:01 ./dnssec-triggerd.service
> > -rw-r--r-- root/root      4640 2016-12-22 12:01 ./dnssec.conf 
> 
> I see that here, too. And it's not a problem in the maintainer scripts
> but in the contents of the package:
> 
> → dpkg -L dnssec-trigger
> /.
> /dnssec-triggerd-keygen.service
> /dnssec-triggerd.service
> /dnssec.conf
> /etc
> […]
> 
> > This looks like a bug to me, in any case it would be a violation of the
> > FHS.
> 
> Definitely both. It was introduced in 0.13-3 as 0.13-2 doesn't show
> that issue:
> 
> → dpkg-deb --contents dnssec-trigger_0.13-2_amd64.deb | egrep
> 'dnssec\.conf|\.service'
> -rw-r--r-- root/root      4640 2016-12-22 10:23
> ./etc/dnssec-trigger/dnssec.conf
> -rw-r--r-- root/root       254 2016-12-22 10:23
> ./lib/systemd/system/dnssec-triggerd-keygen.service
> -rw-r--r-- root/root       573 2016-12-22 10:23
> ./lib/systemd/system/dnssec-triggerd.service
> 
> Just from looking at it, it's though unclear which of the two commits
> (or maybe both together) is really the culprit here:
> 
> https://anonscm.debian.org/git/pkg-dns/dnssec-trigger.git/commit/?id=ca6b92b9b0c5ded050ce0e221f75471ee7db413c
> https://anonscm.debian.org/git/pkg-dns/dnssec-trigger.git/commit/?id=23127353f8396e58cbcc344122ca20b2fa706c9e
> 
> The fact that quilt patches were renamed doesn't make the review of
> the diffs easier. :-/
> 
> 		Regards, Axel
> -- 
>  ,''`.  |  Axel Beckert <abe at debian.org>, http://people.debian.org/~abe/
> : :' :  |  Debian Developer, ftp.ch.debian.org Admin
> `. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
>   `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE
> 
> _______________________________________________
> pkg-dns-devel mailing list
> pkg-dns-devel at lists.alioth.debian.org
> https://lists.alioth.debian.org/mailman/listinfo/pkg-dns-devel