[Pkg-drupal-devel] some Drupal7 patches

[Kinga Marjai]

Hi,

I would like to commit the attached diffs to branches/drupal7 . But first of
all, do I have commit right?

1) During building I get this warning:
[...]
dh_installdeb
dh_gencontrol -- -V'debconf-depends=debconf (>= )'
dpkg-gencontrol: warning: unused substitution variable ${debconf-depends}
dh_md5sums
[...]

It wants to set ${debconf-depends} to $(MINDEBCONFVER) which is not defined.
Also, debian/control doesn't have ${debconf-depends} (anymore I suppose).
Also, debconf dependency is handled by ${misc:Depends} correctly.

2) Use quilt 3.0 source package format. It has many advantages, including
multiple source tarballs for a package. Thus I open a RFC here if it would
be better to ship Drupal7 with some extra modules added this way. Let it be
CCK or any other that may needed by a lot of users.

3) My own patch fixing a bunch of warnings during install (and maybe later).
Drupal7 uses date_create(). As noted by the documentation[1], timezones must
be correctly set and do not use the settings of the system:
"Note: Since PHP 5.1.0 (when the date/time functions were rewritten), every
call to a date/time function will generate a E_NOTICE if the timezone isn't
valid, and/or a E_WARNING message if using the system settings or the TZ
environment variable." As Sid uses PHP 5.3, date_default_timezone_set() must
be used.

If I can't commit them, I would be happy if someone do it for me.

Last but not least, can debian/drupal6.* be deleted?

Regards,
Kinga
[1] http://www.php.net/manual/en/function.date-default-timezone-set.php
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-drupal-devel/attachments/20100313/d42fabec/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 1_dont_set_debconf_dependency.patch
Type: text/x-patch
Size: 381 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-drupal-devel/attachments/20100313/d42fabec/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 2_quilt_package_format.patch
Type: text/x-patch
Size: 698 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-drupal-devel/attachments/20100313/d42fabec/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 3_set_timezone.patch
Type: text/x-patch
Size: 1489 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-drupal-devel/attachments/20100313/d42fabec/attachment-0002.bin>