[Pkg-drupal-devel] some Drupal7 patches

[Luigi Gangitano]

Hi Kinga,

Il giorno 13/mar/2010, alle ore 08.29, Kinga Marjai ha scritto:

> Hi,
> 
> I would like to commit the attached diffs to branches/drupal7 . But first of all, do I have commit right?

You should. :-)

> 1) During building I get this warning:
> [...]
> dh_installdeb
> dh_gencontrol -- -V'debconf-depends=debconf (>= )'
> dpkg-gencontrol: warning: unused substitution variable ${debconf-depends}
> dh_md5sums
> [...]
> 
> It wants to set ${debconf-depends} to $(MINDEBCONFVER) which is not defined. Also, debian/control doesn't have ${debconf-depends} (anymore I suppose). Also, debconf dependency is handled by ${misc:Depends} correctly.

Applied.

> 2) Use quilt 3.0 source package format. It has many advantages, including multiple source tarballs for a package. Thus I open a RFC here if it would be better to ship Drupal7 with some extra modules added this way. Let it be CCK or any other that may needed by a lot of users.

I'd prefer to package drupal modules separately, so that we can update them independently from the main package. drupal7-module-cck would be a good naming scheme.

ATM I don't see real advantages switching to the quilt source format, but I'm open to discussion.

> 3) My own patch fixing a bunch of warnings during install (and maybe later). Drupal7 uses date_create(). As noted by the documentation[1], timezones must be correctly set and do not use the settings of the system:
> "Note: Since PHP 5.1.0 (when the date/time functions were rewritten), every call to a date/time function will generate a E_NOTICE if the timezone isn't valid, and/or a E_WARNING message if using the system settings or the TZ environment variable." As Sid uses PHP 5.3, date_default_timezone_set() must be used.

This should really go upstream. Even more in the Alpha stage of development. We should try to keep differences from upstream at minimum.

> If I can't commit them, I would be happy if someone do it for me.
> 
> Last but not least, can debian/drupal6.* be deleted?

Removed. Didn't show up in my local repository and don't know why. :-)

Regards,

L

--
Luigi Gangitano -- <luigi at debian.org> -- <gangitano at lugroma3.org>
GPG: 1024D/924C0C26: 12F8 9C03 89D3 DB4A 9972  C24A F19B A618 924C 0C26